← Back to issue list

tests: add initial spread testing

View original Github issue

Metadata

Project
fetch-service
Number
#269
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #269 (commit 8fe0091) added initial Spread integration tests to fetch-service: spread.yaml plus snap-config, basic-inspection, update-config and upgrade-revert suites; all 10 lxd-vm tasks passed, resolving #226.

Resolution: closed resolved

Reason: The PR was merged into main as commit 8fe0091 after three approvals, adding spread.yaml and tests/spread/general task files that all passed against Ubuntu 20.04/22.04. It carries "Fixes: #226" (CRAFT-3444), and the test layout persists in the current spread.yaml.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Result from the spread session: ``` $ spread -v lxd-vm 2024-10-14 08:42:54 Found /home/claudio/distro/fetch-service/spread.yaml. 2024-10-14 08:42:56 Project content is packed for delivery (57.47MB). 2024-10-14 08:42:56 Sequence of jobs produced with -seed=1728906176 2024-10-14 08:42:56 If killed, discard servers with: spread -reuse-pid=1112326 -discard 2024-10-14 08:42:56 Allocating lxd-vm:ubuntu-20.04... 2024-10-14 08:42:56 Allocating lxd-vm:ubuntu-22.04... 2024-10-14 08:43:12 Waiting for lxd-vm:ubuntu-22.04 to make SSH available at 10.15.143.2... 2024-10-14 08:43:12 Allocated lxd-vm:ubuntu-22.04. 2024-10-14 08:43:12 Connecting to lxd-vm:ubuntu-22.04... 2024-10-14 08:43:12 Connected to lxd-vm:ubuntu-22.04 at 10.15.143.2. 2024-10-14 08:43:12 Sending project content to lxd-vm:ubuntu-22.04... 2024-10-14 08:43:13 Preparing lxd-vm:ubuntu-22.04 (lxd-vm:ubuntu-22.04)... 2024-10-14 08:43:19 Waiting for lxd-vm:ubuntu-20.04 to make SSH available at 10.15.143.164... 2024-10-14 08:43:19 Allocated lxd-vm:ubuntu-20.04. 2024-10-14 08:43:19 Connecting to lxd-vm:ubuntu-20.04... 2024-10-14 08:43:19 Connected to lxd-vm:ubuntu-20.04 at 10.15.143.164. 2024-10-14 08:43:19 Sending project content to lxd-vm:ubuntu-20.04... 2024-10-14 08:43:20 Preparing lxd-vm:ubuntu-20.04 (lxd-vm:ubuntu-20.04)... 2024-10-14 08:43:39 Preparing lxd-vm:ubuntu-22.04:tests/spread/general/snap-config (lxd-vm:ubuntu-22.04)... 2024-10-14 08:43:39 Executing lxd-vm:ubuntu-22.04:tests/spread/general/snap-config (lxd-vm:ubuntu-22.04) (1/10)... 2024-10-14 08:43:46 Preparing lxd-vm:ubuntu-20.04:tests/spread/general/basic-inspection:strict (lxd-vm:ubuntu-20.04)... 2024-10-14 08:43:48 Executing lxd-vm:ubuntu-20.04:tests/spread/general/basic-inspection:strict (lxd-vm:ubuntu-20.04) (2/10)... 2024-10-14 08:43:49 Restoring lxd-vm:ubuntu-22.04:tests/spread/general/snap-config (lxd-vm:ubuntu-22.04)... 2024-10-14 08:43:50 Preparing lxd-vm:ubuntu-22.04:tests/spread/general/upgrade-revert (lxd-vm:ubuntu-22.04)... 2024-10-14 08:43:50 Executing lxd-vm:ubuntu-22.04:tests/spread/general/upgrade-revert (lxd-vm:ubuntu-22.04) (3/10)... 2024-10-14 08:43:55 Restoring lxd-vm:ubuntu-20.04:tests/spread/general/basic-inspection:strict (lxd-vm:ubuntu-20.04)... 2024-10-14 08:43:55 Preparing lxd-vm:ubuntu-20.04:tests/spread/general/snap-config (lxd-vm:ubuntu-20.04)... 2024-10-14 08:43:56 Executing lxd-vm:ubuntu-20.04:tests/spread/general/snap-config (lxd-vm:ubuntu-20.04) (4/10)... 2024-10-14 08:44:00 Restoring lxd-vm:ubuntu-22.04:tests/spread/general/upgrade-revert (lxd-vm:ubuntu-22.04)... 2024-10-14 08:44:01 Preparing lxd-vm:ubuntu-22.04:tests/spread/general/update-config (lxd-vm:ubuntu-22.04)... 2024-10-14 08:44:04 Executing lxd-vm:ubuntu-22.04:tests/spread/general/update-config (lxd-vm:ubuntu-22.04) (5/10)... 2024-10-14 08:44:05 Restoring lxd-vm:ubuntu-20.04:tests/spread/general/snap-config (lxd-vm:ubuntu-20.04)... 2024-10-14 08:44:06 Preparing lxd-vm:ubuntu-20.04:tests/spread/general/basic-inspection:permissive (lxd-vm:ubuntu-20.04)... 2024-10-14 08:44:08 Executing lxd-vm:ubuntu-20.04:tests/spread/general/basic-inspection:permissive (lxd-vm:ubuntu-20.04) (6/10)... 2024-10-14 08:44:09 Restoring lxd-vm:ubuntu-22.04:tests/spread/general/update-config (lxd-vm:ubuntu-22.04)... 2024-10-14 08:44:10 Preparing lxd-vm:ubuntu-22.04:tests/spread/general/basic-inspection:strict (lxd-vm:ubuntu-22.04)... 2024-10-14 08:44:12 Executing lxd-vm:ubuntu-22.04:tests/spread/general/basic-inspection:strict (lxd-vm:ubuntu-22.04) (7/10)... 2024-10-14 08:44:15 Restoring lxd-vm:ubuntu-20.04:tests/spread/general/basic-inspection:permissive (lxd-vm:ubuntu-20.04)... 2024-10-14 08:44:15 Preparing lxd-vm:ubuntu-20.04:tests/spread/general/upgrade-revert (lxd-vm:ubuntu-20.04)... 2024-10-14 08:44:15 Executing lxd-vm:ubuntu-20.04:tests/spread/general/upgrade-revert (lxd-vm:ubuntu-20.04) (8/10)... 2024-10-14 08:44:19 Restoring lxd-vm:ubuntu-22.04:tests/spread/general/basic-inspection:strict (lxd-vm:ubuntu-22.04)... 2024-10-14 08:44:20 Preparing lxd-vm:ubuntu-22.04:tests/spread/general/basic-inspection:permissive (lxd-vm:ubuntu-22.04)... 2024-10-14 08:44:22 Executing lxd-vm:ubuntu-22.04:tests/spread/general/basic-inspection:permissive (lxd-vm:ubuntu-22.04) (9/10)... 2024-10-14 08:44:25 Restoring lxd-vm:ubuntu-20.04:tests/spread/general/upgrade-revert (lxd-vm:ubuntu-20.04)... 2024-10-14 08:44:26 Preparing lxd-vm:ubuntu-20.04:tests/spread/general/update-config (lxd-vm:ubuntu-20.04)... 2024-10-14 08:44:28 Executing lxd-vm:ubuntu-20.04:tests/spread/general/update-config (lxd-vm:ubuntu-20.04) (10/10)... 2024-10-14 08:44:30 Restoring lxd-vm:ubuntu-22.04:tests/spread/general/basic-inspection:permissive (lxd-vm:ubuntu-22.04)... 2024-10-14 08:44:32 Restoring lxd-vm:ubuntu-22.04 (lxd-vm:ubuntu-22.04)... 2024-10-14 08:44:32 Discarding lxd-vm:ubuntu-22.04... 2024-10-14 08:44:33 Restoring lxd-vm:ubuntu-20.04:tests/spread/general/update-config (lxd-vm:ubuntu-20.04)... 2024-10-14 08:44:34 Restoring lxd-vm:ubuntu-20.04 (lxd-vm:ubuntu-20.04)... 2024-10-14 08:44:34 Discarding lxd-vm:ubuntu-20.04... 2024-10-14 08:44:35 Successful tasks: 10 2024-10-14 08:44:35 Aborted tasks: 0 ``` Fixes: #226 - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- CRAFT-3444

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #269 (commit 8fe0091) added initial Spread integration tests to fetch-service: spread.yaml plus snap-config, basic-inspection, update-config and upgrade-revert suites; all 10 lxd-vm tasks passed, resolving #226.
stealth/space-bunny-alpha — closed resolved Merged PR #269 in commit 8fe0091, adding initial Spread integration tests; all 10 tasks passed on Ubuntu 20.04 and 22.04, resolving #226.
qwen/qwen3.6-35b-a3b — — Merged following approval by three reviewers. Adds initial spread testing infrastructure across 13 files, resolving issue #226. Validation confirms all 10 test tasks passed successfully on Ubuntu 20.04 and 22.04 LXD environments.

Update history

Date Change
created

Related work

  • Likely Fixed By: canonical/fetch-service#226 (confidence 95%)

    The PR body states "Fixes: #226"; that issue (Add fetch service integration tests) was closed by this work.

  • Related To: canonical/fetch-service#299 (confidence 90%)

    Follow-up merged as commit 44d9906 refactoring these spread tests onto a prototype spread extension, superseding the initial yaml in #269.

Related issues

Issue Project State Summary Similarity
#2983 tests: add LXD spread test snapcraft merged Merged PR #2983 as 4b8522a14, adding spread coverage that builds the LXD package with LXD and destructive/host providers; installation checks were deferred.
82%
#2631 spread tests: enable LXD build provider tests snapcraft merged Merged PR #2631 enabled LXD build-provider spread tests and reused early-prepared LXD setup, reducing repeated setup and image-download overhead.
79%
#467 test(spread): use LXD provider for spread tests imagecraft closed PR closed without merge; spread LXD provider changes were implemented across follow-up PRs (#483, #485, #486, #487, #488, #495)
79%
#1272 tests: initial setup for the snapcraft snap tests with spread snapcraft merged Merged PR #1272 as commit 545344442, adding initial Spread-based test infrastructure for the snapcraft snap.
78%
#2682 tests: change default spread provider to lxd outside of travis snapcraft merged Merged PR #2682 (commit 8b41444a3) refactored runtests.sh, defaulted Spread to LXD outside Travis, and configured Travis to use google:.
77%
#485 test(spread): test uc-prepare in lxd imagecraft merged Merged PR adding spread tests for uc-prepare on LXD across core22, core24, and core26 base images.
76%
#5856 fix(spread): pack with lxd for core20 base tests snapcraft merged Merged PR #5856 (commit 66b9ae9f4) updated Spread core20-base tests to pack with LXD.
76%
#521 test(spread): add an improved snap inspector test fetch-service merged Merged in PR #521 (commit 06cd210), adding a more realistic snapd setup to the spread snap inspector test and exposing additional snapd network requests.
75%
#483 test(spread): run snap-preseed tests in lxd imagecraft merged Merged PR #483 to update snap-preseed plugin tests to run in LXD across all systems, addressing CRAFT-5332.
75%
#694 tests(spread): use LXD from `5.21/candidate` rockcraft merged Merged PR #694 in commit 90bc9b34, pinning spread tests to LXD 5.21/candidate to restore main and strengthen LTS regression coverage.
75%