← Back to issue list

test(spread): run snap-preseed tests in lxd

View original Github issue

Metadata

Project
imagecraft
Number
#483
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #483 to update snap-preseed plugin tests to run in LXD across all systems, addressing CRAFT-5332.

Resolution: closed resolved

Reason: The pull request was merged, modifying the spread test configuration to run snap-preseed plugin tests in LXD environments. This ensures the tests execute reliably across all supported systems as requested in CRAFT-5332.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This changes the snap-preseed plugin tests so they run in lxd and on all systems. CRAFT-5332 --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/imagecraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — closed resolved Merged PR #483 to update snap-preseed plugin tests to run in LXD across all systems, addressing CRAFT-5332.
~deepseek/deepseek-pro-latest
Impact: 30
Quick Win: 18
Complexity: 25
Confidence: 80
Actionability: 80
needs review Changes snap-preseed spread test to run in LXD across all systems; CI passing, no reviews yet.
~deepseek/deepseek-pro-latest
Impact: 35
Quick Win: 20
Complexity: 25
Confidence: 70
Actionability: 78
needs review Moves snap-preseed spread tests to run in LXD across all Ubuntu systems; CI green with only spread jobs pending, awaiting review.
~deepseek/deepseek-pro-latest
Impact: 35
Quick Win: 17
Complexity: 20
Confidence: 55
Actionability: 60
keep open Changes snap-preseed spread tests to run in LXD on all systems; CI green, no reviews, build pending.
~deepseek/deepseek-pro-latest
Impact: 30
Quick Win: 15
Complexity: 25
Confidence: 70
Actionability: 65
needs review Updates snap-preseed spread tests to run in LXD and on all systems; CI mostly passing except PR title check.
~deepseek/deepseek-pro-latest
Impact: 35
Quick Win: 14
Complexity: 25
Confidence: 70
Actionability: 55
needs review Updates snap-preseed spread tests to run in LXD and on all systems; CI mostly passing except PR title check.

Update history

Date Change
merged
updated
updated
updated
updated
updated
updated
created

Related issues

Issue Project State Summary Similarity
#1133 test(spread): make LXD refresh in prepare more reliable craft-application closed Closed unmerged; its LXD auto-refresh race fix was superseded by merged PR #1170 (commit fea3e835), which waits for active snap refreshes during spread prepare.
78%
#3957 tests: retry installing lxd snap snapcraft merged PR #3957 merged as 57cd1d97b, adding snapd-testing-tools retries for LXD installation in spread tests to work around intermittent snapd bug 1870201.
77%
#2631 spread tests: enable LXD build provider tests snapcraft merged Merged PR #2631 enabled LXD build-provider spread tests and reused early-prepared LXD setup, reducing repeated setup and image-download overhead.
76%
#269 tests: add initial spread testing fetch-service merged Merged PR #269 (commit 8fe0091) added initial Spread integration tests to fetch-service: spread.yaml plus snap-config, basic-inspection, update-config and upgrade-revert suites; all 10 lxd-vm tasks passed, resolving #226.
75%
#467 test(spread): use LXD provider for spread tests imagecraft closed PR closed without merge; spread LXD provider changes were implemented across follow-up PRs (#483, #485, #486, #487, #488, #495)
74%
#2983 tests: add LXD spread test snapcraft merged Merged PR #2983 as 4b8522a14, adding spread coverage that builds the LXD package with LXD and destructive/host providers; installation checks were deferred.
74%
#485 test(spread): test uc-prepare in lxd imagecraft merged Merged PR adding spread tests for uc-prepare on LXD across core22, core24, and core26 base images.
74%
#1190 test(spread): wait for pending snap auto-refresh before refreshing lxd craft-application closed Superseded by merged PR canonical/craft-application#1170 (fea3e835), which added a broader snap auto-refresh hold and wait; #1190's narrower fix was closed unmerged.
73%
#2937 spread tests: do not attempt to remove snapd snap snapcraft merged Merged in commit b9290bb32; spread tests now skip removing the protected snapd snap, fixing LXD test failures.
73%
#202 Run the tests in a xenial LXC. snapcraft merged PR #202 by come-maiz moved snapcraft's test suite into a Xenial LXC, fixing LP bug #1532213. Merged in Jan 2016 (commit 4e8829dc3) after +1 from sergiusens.
72%