← Back to issue list

inspectors: update request inspection approval

View original Github issue

Metadata

Project
fetch-service
Number
#28
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #28 as commit 7f8029b, making request approval explicit and consistent with artefact inspection; unrecognized requests now return nil.

Resolution: closed resolved

Reason: The maintainer-authored PR received two approvals and was merged as commit 7f8029b, implementing the requested approval API behavior.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Change the request inspection approval API to be consistent with artefact inspection, i.e. have an explicit approval call and return nil even if the request is not recognized by this inspector. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #28 as commit 7f8029b, making request approval explicit and consistent with artefact inspection; unrecognized requests now return nil.
stealth/space-bunny-alpha — closed resolved Merged PR #28 as commit 7f8029b, adding explicit request approval and returning nil for unrecognized requests.
stealth/space-bunny-alpha — closed resolved Merged in fetch-service#28 (commit 7f8029b), adding explicit request approval and returning nil for requests unknown to an inspector.
stealth/space-bunny-alpha — closed resolved Merged PR #28 as commit 7f8029b, aligning request inspection approval with artefact inspection and returning nil for unrecognized requests.
qwen/qwen3.6-35b-a3b — — Merged after two reviewers approved. Updates the request inspection approval API to align with artifact inspection, adding an explicit approval call that returns nil for unrecognized requests.

Update history

Date Change
created

Related issues

Issue Project State Summary Similarity
#41 inspectors: add request opinions fetch-service merged Merged request inspection opinions via PR #41 (commit f687096), adding metadata support for placing artefacts in a pending-verification state.
73%