← Back to issue list

inspectors: add request opinions

View original Github issue

Metadata

Project
fetch-service
Number
#41
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged request inspection opinions via PR #41 (commit f687096), adding metadata support for placing artefacts in a pending-verification state.

Resolution: closed resolved

Reason: PR #41 was merged by maintainer cmatsuoka as commit f687096. Its fuller implementation replaced duplicate PR #37 and included context from the feature/launchpad-integration branch.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Add a separate section in the metadata file for request inspections, where artefacts can be put in pending inspection state for further verification. - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged request inspection opinions via PR #41 (commit f687096), adding metadata support for placing artefacts in a pending-verification state.
qwen/qwen3.6-35b-a3b — closed resolved Added request inspection section to metadata for pending artefact verification. Merged by maintainer, superseding #37 with additional context from the feature/launchpad-integration branch.

Update history

Date Change
created

Related work

  • Duplicate Of: fetch-service#37 (confidence 100%)

    The maintainer explicitly identified #41 as a duplicate, but merged it because it contained additional launchpad-integration context.

Related issues

Issue Project State Summary Similarity
#37 inspectors: add request opinions fetch-service closed Request-opinion metadata work was dropped from #37 and merged via #41 in commit f687096.
83%
#26 inspectors: validate artefacts using opinions fetch-service merged Merged PR #26 (commit b0e6cac) replaced single-format inspection with an opinion-based scheme: all inspectors examine related formats and emit opinions; an artefact is validated only if every capable inspector approves. Fixes fetch-service#23 (CRAFT-2114).
78%
#82 metadata,inspectors: refactor artefact inspection interface fetch-service merged Merged PR #82 in commit a05ab1e, splitting request/response inspection methods, removing redundant APIs and attributes, and moving opinions to a dedicated package.
78%
#16 inspectors: refactor to inspect requests and collect opinions fetch-service merged Merged as commit 68fe099: reorganised inspection flow, added inspect requests and an opinion system replacing artefact annotations. Fixes #15; per-inspector migration followed in #26, #28, #41.
78%
#158 metadata,inspectors: fix inspection result and add tests fetch-service merged Merged in canonical/fetch-service#158 via commits 87f24f5 and f811522; artefact approval now requires a positive request-inspection opinion, with expanded metadata tests.
77%
#140 many: limit inspector access to artefact metadata fetch-service merged Merged PR #140 in commit 19fd664, adding request/response interfaces that restrict inspectors to authorized artefact metadata updates and prevent invalid opinion states.
74%
#28 inspectors: update request inspection approval fetch-service merged Merged PR #28 as commit 7f8029b, making request approval explicit and consistent with artefact inspection; unrecognized requests now return nil.
73%