← Back to issue list

fix(inspectors/git): handle absence of proto and command

View original Github issue

Metadata

Project
fetch-service
Number
#283
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #283 in commit f4c766c: Git inspectors skip artefacts without commands, reject unpack failures, and refuse unshallow requests.

Resolution: closed resolved

Reason: PR #283 was approved and merged as commit f4c766c. It ignores artefacts without command annotations, rejects Git object unpacking errors, and refuses unshallow requests instead of producing a fatal error.

Evaluated by: mr-cal-bot

No scores available.

Issue body

If the git protocol message is missing, the request inspector won't be able to set the command annotation. The artefact inspectors must not error in case of command not being set, and just ignore the artefact in this case. Additionally, reject the artefact instead of generating a fatal error in case of git objects unpacking error, and refuse to process unshallow requests. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #283 in commit f4c766c: Git inspectors skip artefacts without commands, reject unpack failures, and refuse unshallow requests.
stealth/space-bunny-alpha — closed resolved Merged PR #283 in commit f4c766c: Git inspectors skip uncommanded artefacts, reject unpacking errors, and refuse unshallow requests.
qwen/qwen3.6-35b-a3b — — Merged fix for git inspectors handling missing protocol messages and commands. Prevents fatal errors on unpacking failures, rejects unshallow requests, and ignores artifacts without command annotations. Approved by two reviewers.

Update history

Date Change
created

Related issues

Issue Project State Summary Similarity
#166 fix(inspectors/git): make artefact verification less strict fetch-service merged Merged PR #166 relaxed Git artefact verification for binary MIME data, missing versions and NAK responses, resolving #133.
71%