fix(inspectors/git): make artefact verification less strict
Metadata
Current evaluation
Merged PR #166 relaxed Git artefact verification for binary MIME data, missing versions and NAK responses, resolving #133.
Resolution: closed resolved
Reason: PR #166 was merged with commit c96c516, covering message normalization, MIME handling, optional versions, vendor metadata and NAK responses. Its description explicitly states that it fixes #133.
Evaluated by: mr-cal-bot
No scores available.
Issue body
A set of small adjustments to address issues in git inspection,
including:
- normalize messages to remove trailing newline
- smart query response mime type can contain binary data
- allow smart query response without version statement
- add vendor information to smart query and upload-pack metadata
- handle NAK responses in git protocol
- more descriptive debug messages
Go import redirect inspector to be added in a separate PR.
Fixes #133
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #166 relaxed Git artefact verification for binary MIME data, missing versions and NAK responses, resolving #133. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/fetch-service#166, relaxing Git inspection to support binary MIME data, version-less responses and NAKs while adding metadata and debug output. Fixes #133. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes relaxing git inspection strictness via message normalization, binary MIME handling, version-less response support, vendor metadata, and NAK processing. Approved by two reviewers, rebased on main, resolving issue #133. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Related To:
fetch-service#133
(confidence 99%)
The merged PR explicitly declares “Fixes #133” and provides the Git inspection changes intended to resolve it.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #283 fix(inspectors/git): handle absence of proto and command | fetch-service | merged | Merged PR #283 in commit f4c766c: Git inspectors skip artefacts without commands, reject unpack failures, and refuse unshallow requests. | |
| #302 refactor(inspectors): reduce cyclomatic complexity | fetch-service | merged | Merged as commit 6437810: reduced inspector complexity, moved artifact operations into Artefact, and made Git protocol decoding errors reject artifacts; fixes #292. |