← Back to issue list

test: remove artifact location workaround

View original Github issue

Metadata

Project
fetch-service
Number
#392
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged following approval and passing CI. Removed a CI test workflow workaround for artifact locations, as snapcraft resolved the underlying issue. Closes #391.

Suggested action:

No scores available.

Issue body

Artifact location for tests is fixed in snapcraft and the workaround can be removed from the CI test workflow. Fixes #391 Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged following approval and passing CI. Removed a CI test workflow workaround for artifact locations, as snapcraft resolved the underlying issue. Closes #391.

Update history

Date Change
created

Related issues

Issue Project State Summary Similarity
#5529 fix: remove test artifact workaround snapcraft merged Merged a fix that removes the snapcraft test artifact location workaround, as craft-application 3.5 now handles this natively. Approved by two reviewers, passed all CI checks, and modified five files.
82%
#4662 fix(test): do not create 2 snapcraft.yaml and confuse location snapcraft merged Merged a test fix preventing duplicate snapcraft.yaml creation in conflicting root and snap directories. Resolves silent overrides and ensures hooks are detected by clarifying fixture paths. Approved and merged.
73%
#391 Remove test location workaround fetch-service closed Closed as completed after upstream craft-application#752 was published. The test location workaround from #386 was removed to clean up the codebase.
73%
#758 fix(testing): don't change the output artifact location craft-application merged Merged fix for #752 that keeps test output artifacts in the standard location instead of moving them to a spread subdirectory. Approved by reviewers and passed CI checks prior to merge.
72%
#85 test: cleanup test now that we have a new enough snapcraft snapcraft-rocks merged Merged test cleanup after upgrading to a stable snapcraft version. Removes six lines of outdated test code. Approved by one reviewer, passed all CI checks, and successfully merged.
72%
#3609 tests: move legacy snapcraft tests (CRAFT-728) snapcraft merged Merged following reviewer approval and passing CI. Relocated unit tests for the renamed snapcraft_legacy package to tests/legacy, modifying 313 files (+579/-564 lines).
71%
#1877 tests: move test files out of the snapcraft dir snapcraft closed Approved and passing local tests, the changes to move test files out of the snapcraft directory were abandoned after a merge conflict arose. The maintainer closed the request to retry the file relocation later.
70%