fix: remove test artifact workaround
Metadata
Current evaluation
Merged a fix that removes the snapcraft test artifact location workaround, as craft-application 3.5 now handles this natively. Approved by two reviewers, passed all CI checks, and modified five files.
Suggested action: —
No scores available.
Issue body
Fixes in craft-application 3.5 allow `snapcraft test` to run without
workarounds to locate the generated artifact.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `make test`?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix that removes the snapcraft test artifact location workaround, as craft-application 3.5 now handles this natively. Approved by two reviewers, passed all CI checks, and modified five files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Removed the test artifact location workaround in snapcraft test, now natively supported by craft-application 3.5. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged removal of the test artifact location workaround. Updates in craft-application 3.5 natively handle artifact discovery, allowing snapcraft test to execute without manual workarounds. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #392 test: remove artifact location workaround | fetch-service | merged | Merged following approval and passing CI. Removed a CI test workflow workaround for artifact locations, as snapcraft resolved the underlying issue. Closes #391. | |
| #1454 build: update craft-application | charmcraft | merged | Merged after updating the craft-application dependency and adjusting test constants. Approved by two reviewers with no unresolved comments. Changes affect three files with minor line adjustments. | |
| #85 test: cleanup test now that we have a new enough snapcraft | snapcraft-rocks | merged | Merged test cleanup after upgrading to a stable snapcraft version. Removes six lines of outdated test code. Approved by one reviewer, passed all CI checks, and successfully merged. | |
| #133 fix(build): only package craft-application/* | craft-application | merged | Merged a build fix restricting packaging to craft-application/* directories to match Starbase. Approved by three reviewers, passed CI, and caused no coverage change. The single-file update added two and removed six lines. | |
| #1386 fix: final spread test fixes for craft-application | charmcraft | merged | Merged after approval by two reviewers. Resolves final spread test issues for craft-application across seven files, removing 127 lines and adding 104. Changes integrated into the main branch. | |
| #102 test: update craftctl test | snapcraft-rocks | merged | Merged after two approvals and passing CI checks. Updates the spread test to validate the fix for snapcraft-rocks#33, modifying one file with seven added lines. | |
| #1381 fix: fix most spread tests on craft-application | charmcraft | merged | Merged updates fixing most spread tests for craft-application. Two smoketests remain broken. Approved despite minor linting and unit test failures. Resolves CRAFT-2239. | |
| #968 build(deps): update craft-application | rockcraft | merged | Merged after updating craft-application for a CRAFT-4705 demo. Approved by two reviewers with most CI checks passing despite failing snap-tests. Changes affect 17 files with 95 additions and 27 deletions. | |
| #4755 tests: fix devel base snap test | snapcraft | merged | Merged a fix for the devel base snap test. The update ensures snapcraft correctly creates and utilizes the devel base. Approved by two reviewers, passed CI checks, and applied with a minimal one-file change. | |
| #2465 fix(snap): workaround for snapcraft/craft-application bug | charmcraft | merged | Merged a three-line workaround for a snapcraft/craft-application bug. Approved by two reviewers and included in the 4.0.1 release. Non-blocking type-checking warnings were noted but did not prevent integration. |