← Back to issue list

fix: remove test artifact workaround

View original Github issue

Metadata

Project
snapcraft
Number
#5529
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #5529 removed the test-artifact lookup workaround after craft-application 3.5, landing as commit 8fbe76827.

Resolution: closed resolved

Reason: PR #5529 was approved and merged as commit 8fbe76827, removing the artifact-location workaround because craft-application 3.5 now provides the required support.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fixes in craft-application 3.5 allow `snapcraft test` to run without workarounds to locate the generated artifact. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `make test`? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #5529 removed the test-artifact lookup workaround after craft-application 3.5, landing as commit 8fbe76827.
stealth/space-bunny-alpha — closed resolved Merged as commit 8fbe76827, removing Snapcraft's test-artifact workaround now that craft-application 3.5 correctly locates generated artifacts.
stealth/space-bunny-alpha — closed resolved Merged in #5529 via commit 8fbe76827, removing the artifact-location workaround because craft-application 3.5 now locates generated test artifacts correctly.
qwen/qwen3.6-35b-a3b — — Merged a fix that removes the snapcraft test artifact location workaround, as craft-application 3.5 now handles this natively. Approved by two reviewers, passed all CI checks, and modified five files.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Removed the test artifact location workaround in snapcraft test, now natively supported by craft-application 3.5.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#391 Remove test location workaround fetch-service closed Removed the temporary test artifact-location workaround after craft-application fixed test output handling; merged in fetch-service#392 as bdfc9b8.
77%
#392 test: remove artifact location workaround fetch-service merged Merged as commit bdfc9b8, removing the CI test artifact-location workaround after Snapcraft fixed artifact discovery; resolves #391.
75%
#1454 build: update craft-application charmcraft merged Merged in commit 952f070e, updating craft-application and adjusting affected test constants.
74%
#758 fix(testing): don't change the output artifact location craft-application merged Merged in canonical/craft-application#758 via commit f411bf42, fixing #752 by keeping test-command artifacts in the standard output location instead of a spread subdirectory.
74%
#4643 fix(tests): create a suitable build plan snapcraft closed PR #4643 (test fix creating a suitable build plan) was closed unmerged: maintainer mr-cal noted its commits landed via PR #4659 ("fix: update to craft-application latest"), squashed as commit aab0797cf.
70%