Missing Charmcraft artifact in Charm Build
Metadata
Current evaluation
Fixed in PR #465. The go-module-git inspector overrode the charmcraft inspector, suppressing the charmcraft artifact. Support for .yml extensions was explicitly rejected.
Suggested action: —
No scores available.
Issue body
### Bug Description
For Build: https://launchpad.net/~vyomydv/fs-output-test/+charm/fs-output-test/+build/39002
FS Manifest: https://launchpad.net/~vyomydv/fs-output-test/+charm/fs-output-test/+build/39002/+files/CHARMRECIPEBUILD-39002_metadata.json
Even though this is a build for a charm with a valid `charmcraft.yaml` at the root (⚠️ Matching on `.yaml` is harcoded in code, it should support `.yml` as well), still no artifact with mimetype: `application/x.canonical.charmcraft` is present in the output.
What may be happening is that go-module-git inspector is overriding charmcraft inspector:
```json
{
"artifact-metadata-version": "0.2",
"request-inspection": {
"git.upload-pack": {
"opinion": "Pending",
"reason": "valid URL for git upload-pack",
"annotations": {
"client-request": [
"command=fetch",
"agent=git/2.34.1",
"",
"thin-pack",
"no-progress",
"include-tag",
"ofs-delta",
"deepen 1",
"want 1be61f6443954fcfc9589b1ba836eb898a153493",
"done"
],
"command": "fetch",
"is-shallow": true,
"num-wants": 1,
"project": "",
"protocol": "version=2",
"repository": "https://git.launchpad.net:443/fs-output-test",
"server": "git.launchpad.net",
"wants": [
"1be61f6443954fcfc9589b1ba836eb898a153493"
]
}
},
"go.module.git": {
"opinion": "Unknown",
"reason": "unsupported origin"
}
},
"response-inspection": {
"craft.charmcraft": {
"opinion": "Approved",
"reason": "charmcraft repository found"
},
"craft.rockcraft": {
"opinion": "Unknown",
"reason": "git repository does not contain a rockcraft.yaml file"
},
"craft.snapcraft": {
"opinion": "Unknown",
"reason": "git repository does not contain a snapcraft.yaml file"
},
"craft.sourcecraft": {
"opinion": "Unknown",
"reason": "git repository does not contain a sourcecraft.yaml file"
},
"git.upload-pack": {
"opinion": "Unknown",
"reason": "git fetch response is valid but content is unknown",
"annotations": {
"git-checkout-path": "/var/snap/fetch-service/common/spool/fd6036d2fb1543a19b0916a77904d88a/cache/git-3184041449",
"heads": {
"master": "1be61f6443954fcfc9589b1ba836eb898a153493"
},
"server-response": [
"shallow-info",
"shallow 1be61f6443954fcfc9589b1ba836eb898a153493",
"",
"packfile"
],
"tags": {}
}
},
"go.module.git": {
"opinion": "Rejected",
"reason": "cannot find go module version tag",
"annotations": {
"go": "1.23",
"module": "github.com/Vyom-Yadav/test-charm"
}
}
},
"result": "Rejected",
"metadata": {
"type": "application/x.go.module.git-repo",
"sha1": "89061010f9f0dc137e9de2009027a639c71c6321",
"sha256": "8063a74367d3269fe1c0fc14e9d5c11d053b6be64a3fb7ee3f1d9c90bd2da54d",
"size": 13463,
"name": "test-charm",
"version": "",
"vendor": "Vyom-Yadav",
"description": "",
"author": "",
"license": "Apache-2.0"
},
"downloads": [
{
"start-time": "2025-07-23T05:19:45.3836462Z",
"end-time": "2025-07-23T05:19:45.698389658Z",
"method": "POST",
"url": "https://git.launchpad.net:443/fs-output-test/git-upload-pack",
"address": "10.133.32.70:52740",
"user-agent": "git/2.34.1",
"request-header": {
"Accept": [
"application/x-git-upload-pack-result"
],
"Accept-Encoding": [
"deflate, gzip, br, zstd"
],
"Content-Length": [
"172"
],
"Content-Type": [
"application/x-git-upload-pack-request"
],
"Git-Protocol": [
"version=2"
],
"User-Agent": [
"git/2.34.1"
]
},
"status-code": 200,
"status": "200 OK",
"content-type": "application/x-git-upload-pack-result",
"response-header": {
"Content-Type": [
"application/x-git-upload-pack-result"
],
"Date": [
"Wed, 23 Jul 2025 05:19:45 GMT"
],
"Server": [
"TwistedWeb/20.3.0+lp9"
]
}
}
]
},
```
```json
"response-inspection": {
"craft.charmcraft": {
"opinion": "Approved",
"reason": "charmcraft repository found"
},
```
It found `charmcraft.yaml`, but I think go-module-git inspector overrided the metadata from the charmcraft inspector. The manifest is attached and there is no charmcraft artifact in there. I suspect this can happen with other star-craft too.
### To Reproduce
https://launchpad.net/~vyomydv/fs-output-test/+charm/fs-output-test/+build/39002
### Relevant log output
```shell
N/A
```
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Fixed in PR #465. The go-module-git inspector overrode the charmcraft inspector, suppressing the charmcraft artifact. Support for .yml extensions was explicitly rejected. |
Update history
| Date | Change |
|---|---|
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #680 The charmcraft.yaml is not longer optional for build command (CRAFT-784). | charmcraft | merged | Merged. The type key in charmcraft.yaml is now mandatory for the build command. Config schema validation enforces this during unmarshalling, with a default fallback for empty configs. Approved by two reviewers and passed CI. | |
| #872 charm artifacts from reactive plugin are missing valuable build metadata | charmcraft | open | Reactive charms built via charmcraft's reactive plugin lack the .build.manifest file that charm-tools generates, and manifest.yaml omits charm-tools version. Triaged (Status: Triaged, Type: Bug); internal ticket CHARMCRAFT-654 created 2025-09-17; no code change yet. |