fix(inspectors/gomod): set metadata if artifact approved
Metadata
Current evaluation
Merged in canonical/fetch-service#465 (commit 1309dc6) and released in 0.10.0; gomod metadata is now set only after approval, preventing overwrites by non-approving inspectors.
Resolution: closed resolved
Reason: PR #465 merged as commit 1309dc6 and is listed in the 0.10.0 changelog. It defers metadata assignment until approval and removes invalid external Git-module URLs and redundant unknown opinions.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Don't set the artifact metadata before the inspector approves it, or
it may be approved by a different inspector and retain the metadata
set by the non-approving inspector. In this case, the artifact was
approved by the Charmcraft inspector, and its metadata was rewritten
by the go module inspector before marking it as rejected.
Also remove external URLs from the list of valid URLs for go modules
in git repositories, and remove unnecessary explicit unknown opinions
from the session report.
Additional testing to be added in a separate PR when a disambiguation
strategy for git repositories is defined.
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/fetch-service#465 (commit 1309dc6) and released in 0.10.0; gomod metadata is now set only after approval, preventing overwrites by non-approving inspectors. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #465 as commit 1309dc6, delaying gomod metadata assignment until approval to prevent overwrites by non-approving inspectors; also removed invalid URLs and redundant opinions. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix delaying gomod metadata assignment until approval, preventing incorrect overwrites by other inspectors. Also removes invalid external URLs for go modules in git repos and cleans up session reports. Approved by two reviewers and passed CI checks. |
Update history
| Date | Change |
|---|---|
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #158 metadata,inspectors: fix inspection result and add tests | fetch-service | merged | Merged in canonical/fetch-service#158 via commits 87f24f5 and f811522; artefact approval now requires a positive request-inspection opinion, with expanded metadata tests. |