fix(inspectors/gomod): set metadata if artifact approved
Metadata
Current evaluation
Merged fix delaying gomod metadata assignment until approval, preventing incorrect overwrites by other inspectors. Also removes invalid external URLs for go modules in git repos and cleans up session reports. Approved by two reviewers and passed CI checks.
Suggested action: —
No scores available.
Issue body
Don't set the artifact metadata before the inspector approves it, or
it may be approved by a different inspector and retain the metadata
set by the non-approving inspector. In this case, the artifact was
approved by the Charmcraft inspector, and its metadata was rewritten
by the go module inspector before marking it as rejected.
Also remove external URLs from the list of valid URLs for go modules
in git repositories, and remove unnecessary explicit unknown opinions
from the session report.
Additional testing to be added in a separate PR when a disambiguation
strategy for git repositories is defined.
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix delaying gomod metadata assignment until approval, preventing incorrect overwrites by other inspectors. Also removes invalid external URLs for go modules in git repos and cleans up session reports. Approved by two reviewers and passed CI checks. |
Update history
| Date | Change |
|---|---|
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #158 metadata,inspectors: fix inspection result and add tests | fetch-service | merged | Merged following two reviewer approvals and passing CI. Fixed inspection result logic required for artifact approval, added clarifying comments, and improved test coverage for artifact metadata. | |
| #606 refactor: set inspector opinion and artifact metadata | fetch-service | merged | Merged a refactor updating inspector opinion and artifact metadata in one call to prevent data loss. Approved by two reviewers, passed CI except CLA verification, and implemented after prior discussion. |