← Back to issue list

feat(inspectors): add chisel-releases inspector

View original Github issue

Metadata

Project
fetch-service
Number
#445
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit b542989 and released in fetch-service 0.10.0: adds the chisel-releases inspector, default config for codeload.github.com chisel-releases, multi-key decoding, and a spread test — reviving unmerged #333.

Resolution: closed resolved

Reason: PR #445 was approved and merged into main as commit b542989, adding inspectors/chisel/release.go plus docs (docs/reference/chisel_release.rst) and a changelog entry shipped in 0.10.0. The author reworked the earlier unmerged PR #333 by merging main into it, resolving conflicts, and adding default config access to codeload.github.com/canonical/chisel-releases.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR is a follow-up to #333, which never got merged. I merged in `main` and resolved the few conflicts, plus added some new commits: - Added default config to allow access to `https://codeload.github.com:443/canonical/chisel-releases/`, which is where the chisel metadata lives; - Update a key-decoding function to support multiple public keys, because chisel hits the esm archives and the default config [for those](https://codeload.github.com:443/canonical/chisel-releases/) has multiple keys - Added a spread test to actually validate the inspector. Other than that, the original code by Rafid is unchanged.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit b542989 and released in fetch-service 0.10.0: adds the chisel-releases inspector, default config for codeload.github.com chisel-releases, multi-key decoding, and a spread test — reviving unmerged #333.
stealth/space-bunny-alpha — closed resolved Merged as commit b542989, shipping the chisel-releases inspector, default codeload.github.com access config, multi-public-key decoding, and a spread test; released in fetch-service 0.10.0.
stealth/space-bunny-alpha — closed resolved Merged into main: adds the chisel-releases inspector, GitHub metadata access defaults, multi-public-key decoding, and a spread test, superseding unmerged #333.
qwen/qwen3.6-35b-a3b — — Merged into main following resolution of conflicts with #333. Introduces the chisel-releases inspector, including default config for GitHub metadata access, updated multi-key decoding, and a validation spread test. Approved by two reviewers with all CI checks passing.

Update history

Date Change
created

Related work

  • Likely Fixed By: fetch-service#333 (confidence 80%)

    Sibling openpgp key decoding in inspectors/apt was updated to support multiple public keys, needed because the default esm/chisel config references several keys.

  • Related To: fetch-service#606 (confidence 45%)

    Later refactor (commit d73ca4a) set inspector opinion and artifact metadata, touching the code added by this PR.

Related issues

Issue Project State Summary Similarity
#333 feat(inspectors): add chisel release inspector fetch-service closed Closed unmerged after the author departed; the chisel-releases inspector was later merged via #445 (commit b542989) and shipped in fetch-service 0.10.0.
88%