refactor: set inspector opinion and artifact metadata
Metadata
Current evaluation
Merged in canonical/fetch-service#606 (commit d73ca4a), combining inspector opinion and artifact metadata updates to prevent metadata loss or omissions.
Resolution: closed resolved
Reason: PR #606 was merged as commit d73ca4a after maintainer review. It updates opinion and artifact metadata in one call, covering unrecognized, approved, and rejected artifacts.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Change inspector opinion setting to also set the artifact metadata
in the same call. This prevents accidental metadata overwrites when
the artifact format is not recognized, or missing metadata when the
artifact is approved or rejected.
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/fetch-service#606 (commit d73ca4a), combining inspector opinion and artifact metadata updates to prevent metadata loss or omissions. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #606, combining inspector opinion and artifact metadata updates in one call to prevent metadata loss or omissions for unknown formats and approved or rejected artifacts. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a refactor updating inspector opinion and artifact metadata in one call to prevent data loss. Approved by two reviewers, passed CI except CLA verification, and implemented after prior discussion. |
Update history
| Date | Change |
|---|---|
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #158 metadata,inspectors: fix inspection result and add tests | fetch-service | merged | Merged in canonical/fetch-service#158 via commits 87f24f5 and f811522; artefact approval now requires a positive request-inspection opinion, with expanded metadata tests. | |
| #23 Refactor inspector interaction strategy | fetch-service | closed | Opinion-based inspector communication was implemented for apt/deb artifact checks in merged PR canonical/fetch-service#61 (commit 566f57c), resolving #23. | |
| #26 inspectors: validate artefacts using opinions | fetch-service | merged | Merged PR #26 (commit b0e6cac) replaced single-format inspection with an opinion-based scheme: all inspectors examine related formats and emit opinions; an artefact is validated only if every capable inspector approves. Fixes fetch-service#23 (CRAFT-2114). | |
| #82 metadata,inspectors: refactor artefact inspection interface | fetch-service | merged | Merged PR #82 in commit a05ab1e, splitting request/response inspection methods, removing redundant APIs and attributes, and moving opinions to a dedicated package. | |
| #16 inspectors: refactor to inspect requests and collect opinions | fetch-service | merged | Merged as commit 68fe099: reorganised inspection flow, added inspect requests and an opinion system replacing artefact annotations. Fixes #15; per-inspector migration followed in #26, #28, #41. |