metadata,inspectors: fix inspection result and add tests
Metadata
Current evaluation
Merged in canonical/fetch-service#158 via commits 87f24f5 and f811522; artefact approval now requires a positive request-inspection opinion, with expanded metadata tests.
Resolution: closed resolved
Reason: Merged PR canonical/fetch-service#158 contains commits 87f24f5 and f811522. It corrected approval to require a positive request-inspection opinion and added comments and broader artefact-metadata test coverage.
Evaluated by: mr-cal-bot
No scores available.
Issue body
For an artefact to be marked as approved it's also necessary to have
a positive opinion in request inspection. Also add comments and improve
coverage of artefact metadata tests.
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/fetch-service#158 via commits 87f24f5 and f811522; artefact approval now requires a positive request-inspection opinion, with expanded metadata tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/fetch-service#158 (commits 87f24f5/f811522), fixing artefact approval to require a positive request-inspection opinion and expanding metadata tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged following two reviewer approvals and passing CI. Fixed inspection result logic required for artifact approval, added clarifying comments, and improved test coverage for artifact metadata. |
Update history
| Date | Change |
|---|---|
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #606 refactor: set inspector opinion and artifact metadata | fetch-service | merged | Merged in canonical/fetch-service#606 (commit d73ca4a), combining inspector opinion and artifact metadata updates to prevent metadata loss or omissions. | |
| #82 metadata,inspectors: refactor artefact inspection interface | fetch-service | merged | Merged PR #82 in commit a05ab1e, splitting request/response inspection methods, removing redundant APIs and attributes, and moving opinions to a dedicated package. | |
| #41 inspectors: add request opinions | fetch-service | merged | Merged request inspection opinions via PR #41 (commit f687096), adding metadata support for placing artefacts in a pending-verification state. | |
| #26 inspectors: validate artefacts using opinions | fetch-service | merged | Merged PR #26 (commit b0e6cac) replaced single-format inspection with an opinion-based scheme: all inspectors examine related formats and emit opinions; an artefact is validated only if every capable inspector approves. Fixes fetch-service#23 (CRAFT-2114). | |
| #16 inspectors: refactor to inspect requests and collect opinions | fetch-service | merged | Merged as commit 68fe099: reorganised inspection flow, added inspect requests and an opinion system replacing artefact annotations. Fixes #15; per-inspector migration followed in #26, #28, #41. | |
| #465 fix(inspectors/gomod): set metadata if artifact approved | fetch-service | merged | Merged in canonical/fetch-service#465 (commit 1309dc6) and released in 0.10.0; gomod metadata is now set only after approval, preventing overwrites by non-approving inspectors. | |
| #137 inspectors/pip: add metadata file inspector | fetch-service | merged | Merged as canonical/fetch-service#137 (commit 87a3cfe), adding a PyPI *.metadata inspector to reduce rejected downloads. |