metadata,inspectors: fix inspection result and add tests
Metadata
Current evaluation
Merged following two reviewer approvals and passing CI. Fixed inspection result logic required for artifact approval, added clarifying comments, and improved test coverage for artifact metadata.
Suggested action: —
No scores available.
Issue body
For an artefact to be marked as approved it's also necessary to have
a positive opinion in request inspection. Also add comments and improve
coverage of artefact metadata tests.
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged following two reviewer approvals and passing CI. Fixed inspection result logic required for artifact approval, added clarifying comments, and improved test coverage for artifact metadata. |
Update history
| Date | Change |
|---|---|
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #82 metadata,inspectors: refactor artefact inspection interface | fetch-service | merged | Merged after refactoring the artefact inspection interface. Redundant methods were removed, separate request and response inspection methods were added, and opinions were moved to a dedicated package. Approved and passed CI. | |
| #606 refactor: set inspector opinion and artifact metadata | fetch-service | merged | Merged a refactor updating inspector opinion and artifact metadata in one call to prevent data loss. Approved by two reviewers, passed CI except CLA verification, and implemented after prior discussion. | |
| #465 fix(inspectors/gomod): set metadata if artifact approved | fetch-service | merged | Merged fix delaying gomod metadata assignment until approval, preventing incorrect overwrites by other inspectors. Also removes invalid external URLs for go modules in git repos and cleans up session reports. Approved by two reviewers and passed CI checks. | |
| #200 docs: document the Maven inspectors | fetch-service | merged | Merged documentation update adding Maven inspector details across three files (+124/-0). Resolves issue #184. Approved by two reviewers. A minor failing unit test was noted but addressed separately, allowing the merge to proceed. | |
| #140 many: limit inspector access to artefact metadata | fetch-service | merged | Merged after two approvals and CI. Refactored inspector access to artefact metadata via interfaces to prevent arbitrary modifications and enforce single-call setting. Enhances API safety and readability without functional changes. | |
| #37 inspectors: add request opinions | fetch-service | closed | Closed and dropped in favor of PR #41. Reviewers requested clarification on inspector and artifact interactions, prompting the author to abandon this branch and re-implement the pending inspection metadata feature in PR #41. | |
| #53 ci: fix TICS test results artifact name | starflow | merged | Merged a one-line fix to correct the TICS test results artifact name in the CI pipeline. Approved by two reviewers with all checks passing. | |
| #400 fix: bin inspector must not reject non-tar artifacts | fetch-service | merged | Merged fix updating the bin inspector to skip non-tar xzipped artifacts instead of returning an error. Approved by two reviewers and passed CI, resolving the artifact rejection issue. | |
| #536 fix: increase inspection timeout to 5 minutes | fetch-service | merged | Merged after two approvals. Increases the default inspection timeout from 60 to 300 seconds to handle large artifacts, with plans to make it configurable. Passed CI checks and integrated into the codebase. |