← Back to issue list

feat: scaffolding for per-session secrets

View original Github issue

Metadata

Project
fetch-service
Number
#481
Type
pull request
State
merged
Author
tigarmo
Labels
PR: Squash
Created
Updated
Closed

Current evaluation

PR #481 merged as commit f39d929: adds scaffolding for per-session secrets, with the create-session endpoint accepting a 'secrets' key (validation only). fetchctl secrets wiring deferred to a follow-up.

Resolution: closed resolved

Reason: The pull request itself was merged into main as commit f39d929 ('feat: scaffolding for per-session secrets (#481)') with all CI checks passing and CLA check signed. The maintainer explicitly deferred the reviewer-suggested fetchctl integration to a separate PR rather than expanding the already-large changeset.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This changeset does the refactoring and infrastructure changes necessary to support per-session secrets. The 'create session' endpoint now supports a 'secrets' key that at the moment does some validation but nothing else. - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #481 merged as commit f39d929: adds scaffolding for per-session secrets, with the create-session endpoint accepting a 'secrets' key (validation only). fetchctl secrets wiring deferred to a follow-up.
stealth/space-bunny-alpha — closed resolved Merged PR #481 as commit f39d929, adding scaffolding for per-session secrets and create-session validation of a secrets key. fetchctl integration was deferred to a separate PR.
qwen/qwen3.6-35b-a3b — — Merged after passing CI and two approvals. Adds scaffolding for per-session secrets with a validated key in the create session endpoint. Author plans to extend support to fetchctl separately.

Update history

Date Change
created

Related work

  • Related To: canonical/fetch-service#480 (confidence 88%)

    Preceding merged PR that added per-session inspector conf, referenced by the reviewer as the model for the secrets design; tigarmo noted a separate issue was created for the fetchctl follow-up.

Related issues

Issue Project State Summary Similarity
#483 feat(secrets): support for 'basic' secrets fetch-service merged Merged PR #483 as commit 83d6fa6, adding support for basic-auth secrets, including validation, HTTP Authorization header injection, session plumbing, and tests.
72%
#600 docs: explain session secrets in Security doc fetch-service merged Merged #600 in commit e059872, adding Security documentation that explains per-session credentials and how Fetch Service handles session secrets across four files.
70%