← Back to issue list

feat(secrets): support for 'basic' secrets

View original Github issue

Metadata

Project
fetch-service
Number
#483
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #483 as commit 83d6fa6, adding support for basic-auth secrets, including validation, HTTP Authorization header injection, session plumbing, and tests.

Resolution: closed resolved

Reason: PR #483 received three approvals and passed all reported CI checks before being merged as commit 83d6fa6. The change implements basic-auth secret support.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #483 as commit 83d6fa6, adding support for basic-auth secrets, including validation, HTTP Authorization header injection, session plumbing, and tests.
stealth/space-bunny-alpha — closed resolved Merged basic-secrets support in canonical/fetch-service#483 via commit 83d6fa6, with three approvals and all reported CI checks passing.
qwen/qwen3.6-35b-a3b — — Merged feature adding support for basic secrets. Approved by three reviewers, passed all CI checks, and modified 14 files with 240 additions and 14 deletions.

Update history

Date Change
created

Related issues

Issue Project State Summary Similarity
#657 feat!(secrets): remove secrets craft-application merged Merged PR #657 in commit ad52b56b, removing built-in secrets support; applications can instead integrate secrets through the prototype secrets service.
75%
#481 feat: scaffolding for per-session secrets fetch-service merged PR #481 merged as commit f39d929: adds scaffolding for per-session secrets, with the create-session endpoint accepting a 'secrets' key (validation only). fetchctl secrets wiring deferred to a follow-up.
72%
#591 docs: add how-to for passing secrets fetch-service merged Merged PR #591 (commit abd7f5c) added a 51-line how-to for passing secrets, including a basic-auth example.
72%
#185 feat: add secrets API craft-cli merged Merged PR #185 (commit e988947) adds Emitter.set_secrets(), masking registered strings as "*****" across emitter messages, log calls, spinner, progress bar and streaming brief prefix via Printer._apply_secrets.
70%