← Back to issue list

feat(secrets): support for 'basic' secrets

View original Github issue

Metadata

Project
fetch-service
Number
#483
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged feature adding support for basic secrets. Approved by three reviewers, passed all CI checks, and modified 14 files with 240 additions and 14 deletions.

Suggested action: —

No scores available.

Issue body

- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged feature adding support for basic secrets. Approved by three reviewers, passed all CI checks, and modified 14 files with 240 additions and 14 deletions.

Update history

Date Change
created

Related issues

Issue Project State Summary Similarity
#657 feat!(secrets): remove secrets craft-application merged Merged after two approvals and passing CI. The change removes built-in secrets functionality, deleting 595 lines across eight files. Applications can instead implement the prototype secrets service if needed.
77%
#104 feat: support build-secrets in managed-mode craft-application merged Merged into main. Implements build-secrets support in managed-mode by encoding secrets into the host-application environment for the managed instance to decode and re-render. Approved by two reviewers, passed CI, and achieved 100% diff coverage.
76%
#185 feat: add secrets API craft-cli merged Merged the secrets API feature, adding Emitter.set_secrets to mask sensitive strings across all CLI outputs. Approved by two reviewers, passed CI checks, and achieved 100% diff coverage. Resolves issue 184.
76%
#378 feat: enable build-secrets rockcraft merged Merged to enable build-secrets. Approved by two reviewers, the update modifies six files (+48/-4). The target branch was adjusted to feature/build-secrets before final merge.
75%
#532 feat: add 'macaroon' secret type fetch-service merged Merged addition of a 'macaroon' secret type to align with Store implementation. Requires base64-encoded input. Approved by two reviewers, passed CI checks, and merged despite one failing test. Modified 11 files.
71%
#591 docs: add how-to for passing secrets fetch-service merged Merged documentation update adding a how-to guide for passing secrets with a basic-auth example. Approved by two reviewers, the change adds 51 lines across two files. Core CI checks passed, and the guide was integrated into the repository.
71%