← Back to issue list

chore: update spread test to use utility functions

View original Github issue

Metadata

Project
fetch-service
Number
#603
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged maintainer PR replacing direct curl calls in spread tests with utility functions from spread/utils.sh and extending create_session to accept optional secret definitions. Approved by two reviewers with all CI checks passing.

Suggested action:

No scores available.

Issue body

Replace direct curl calls in spread tasks with helper functions defined in `spread/utils.sh`. Also extend the `create_session` call to accept optional secret definitions. - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged maintainer PR replacing direct curl calls in spread tests with utility functions from spread/utils.sh and extending create_session to accept optional secret definitions. Approved by two reviewers with all CI checks passing.

Update history

Date Change
created

Related issues

Issue Project State Summary Similarity
#11 chore: enable spread tests snapcraft-rocks merged Merged to enable spread tests on CI using new self-hosted runners. Downgrades actions/checkout to v3 for compatibility. Approved by one reviewer.
78%
#753 chore(services/testing): reduce spread verbosity level craft-application merged Merged changes that disable verbose mode for the spread test command to reduce output noise. Approved by reviewers, passed all CI checks, and integrated into the codebase.
77%
#4720 chore(core24): update package for linter spread test snapcraft merged Merged a one-line package update for a linter spread test to address a time_t compatibility issue. Approved by two reviewers and passed CI checks.
76%
#4634 chore: spread cleanup snapcraft merged Merged by maintainer sergiusens after three reviewers approved. The PR cleaned up spread configuration across 85 files, removing 358 lines and adding 115. All CI checks passed with 100% coverage on modified code.
76%
#636 chore(ci): move base devel spread tests to manual rockcraft merged Merged CI changes repurposing the large spread test run into a manual cron job. This isolates flaky base devel tests while preserving visibility via scheduled execution. Approved by two reviewers and applied across six files.
75%
#1575 chore: make spread config a bit nicer charmcraft merged Merged maintainer lengau's pull request to improve spread configuration formatting. The change added four lines across two files. Approved by two reviewers with zero unresolved comments and no CI checks required.
74%
#251 chore(spread): add a multipass backend for spread imagecraft merged Merged changes adding a multipass backend for spread, adapted from Charmcraft. The single-file update added 50 lines, received approval from two reviewers, and passed CI checks before integration.
72%
#4674 chore(spread): miscellaneous spread fixes for core24 snapcraft merged Merged following approval from two reviewers and successful code coverage checks. The change applies miscellaneous spread fixes for core24 across four files, resulting in a +9/-5 line diff.
72%
#4668 chore(spread): core22 provider setup cleanup snapcraft merged Merged cleanup of the core22 provider setup in spread configuration. Fixes the cleanup process to target the correct provider. Approved by two reviewers, passed CI, and achieved full test coverage on modified lines across 12 files.
70%
#2264 chore: migrate provider test from GHA to spread charmcraft merged Merged after two reviewers approved. The update migrated provider tests from GitHub Actions to Spread. Ephemeral Spread failures were resolved on re-run, passing CI and landing the commit in the merge queue.
70%