← Back to issue list

chore(spread): miscellaneous spread fixes for core24

View original Github issue

Metadata

Project
snapcraft
Number
#4674
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged following approval from two reviewers and successful code coverage checks. The change applies miscellaneous spread fixes for core24 across four files, resulting in a +9/-5 line diff.

Suggested action:

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox run -m lint`? - [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged following approval from two reviewers and successful code coverage checks. The change applies miscellaneous spread fixes for core24 across four files, resulting in a +9/-5 line diff.
qwen3.6-35b-a3b-mtp-q6 Merged miscellaneous spread fixes for core24. Changes passed linting and tests, with full coverage on modified lines. Successfully integrated into the main branch.
qwen3.6-35b-a3b-mtp-q6 Merged miscellaneous spread fixes for core24 by maintainer tigarmo. The changes passed code coverage validation and were successfully integrated into the codebase.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4689 chore(spread): remove remove hook test for core24 snapcraft merged Merged after two reviewers approved and CI passed. The change removes a spread test for core24 base instance removal, as it was unrelated to core24 enablement. Two files were modified, reducing the codebase by 58 lines.
85%
#4634 chore: spread cleanup snapcraft merged Merged by maintainer sergiusens after three reviewers approved. The PR cleaned up spread configuration across 85 files, removing 358 lines and adding 115. All CI checks passed with 100% coverage on modified code.
81%
#251 chore(spread): add a multipass backend for spread imagecraft merged Merged changes adding a multipass backend for spread, adapted from Charmcraft. The single-file update added 50 lines, received approval from two reviewers, and passed CI checks before integration.
78%
#4668 chore(spread): core22 provider setup cleanup snapcraft merged Merged cleanup of the core22 provider setup in spread configuration. Fixes the cleanup process to target the correct provider. Approved by two reviewers, passed CI, and achieved full test coverage on modified lines across 12 files.
78%
#1575 chore: make spread config a bit nicer charmcraft merged Merged maintainer lengau's pull request to improve spread configuration formatting. The change added four lines across two files. Approved by two reviewers with zero unresolved comments and no CI checks required.
78%
#4056 spread: core24 testing infra snapcraft merged Merged after receiving two approvals and passing CI checks. Implements core24 testing infrastructure for spread, changing two files with a net addition of 16 lines. Code coverage remained unchanged.
76%
#5030 chore(merge): 8.4.0 into main snapcraft merged Merged version 8.4.0 into main. Approved by two reviewers with passing CI checks. The update modified 33 files, adding 930 lines and removing 151. A maintainer clarified an unrelated launchpad 503 error triggered a core20 spread test failure.
75%
#5502 chore(merge): 8.9.2 into main snapcraft merged Merged version 8.9.2 into main by maintainer mr-cal. Approved by two reviewers and passing most CI checks despite one failing test. Adds YAML syntax error reporting tests and project variable evaluations for core24 and core22.
75%
#2028 chore: two small non-code changes charmcraft merged Merged following approval from two reviewers. The pull request implements two minor non-code changes across two files, yielding a five-line addition and two-line deletion diff. No code modifications were included.
74%
#4720 chore(core24): update package for linter spread test snapcraft merged Merged a one-line package update for a linter spread test to address a time_t compatibility issue. Approved by two reviewers and passed CI checks.
74%