← Back to issue list

chore(spread): miscellaneous spread fixes for core24

View original Github issue

Metadata

Project
snapcraft
Number
#4674
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4674 as commit 3b82c25f0, applying miscellaneous core24 Spread fixes across four files (+9/-5).

Resolution: closed resolved

Reason: PR #4674 was approved by two reviewers and merged into the project as commit 3b82c25f0, with all modified lines covered by tests.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox run -m lint`? - [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4674 as commit 3b82c25f0, applying miscellaneous core24 Spread fixes across four files (+9/-5).
stealth/space-bunny-alpha — closed resolved Merged PR #4674 (commit 3b82c25f0), applying core24 spread fixes across four files (+9/-5), with two approvals and full coverage of modified lines.
qwen/qwen3.6-35b-a3b — — Merged following approval from two reviewers and successful code coverage checks. The change applies miscellaneous spread fixes for core24 across four files, resulting in a +9/-5 line diff.
qwen3.6-35b-a3b-mtp-q6 — — Merged miscellaneous spread fixes for core24. Changes passed linting and tests, with full coverage on modified lines. Successfully integrated into the main branch.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4689 chore(spread): remove remove hook test for core24 snapcraft merged Merged #4689 in commit 8ce88c44b, removing the core24 remove-hook spread test because it covered base-instance cleanup, not core24 enablement.
78%
#1575 chore: make spread config a bit nicer charmcraft merged Merged #1575 as commit 45704d06, improving Charmcraft's Spread configuration with four added lines across two files.
77%
#4668 chore(spread): core22 provider setup cleanup snapcraft merged Merged PR #4668 (commit 5d03a0a6b), cleaning up the core22 Spread provider setup and making cleanup target the correct provider.
76%
#4634 chore: spread cleanup snapcraft merged Merged spread cleanup in #4634, simplifying 85 files with 115 additions and 358 deletions; Codecov reported all modified coverable lines were tested.
76%
#251 chore(spread): add a multipass backend for spread imagecraft merged Merged PR #251 as commit e27dab0, adding a 50-line Multipass backend for Spread adapted from Charmcraft after two reviewer approvals.
75%
#4720 chore(core24): update package for linter spread test snapcraft merged Merged PR #4720 (commit 429a69ce9) updated the package used by the core24 linter spread test after its time_t change.
74%
#4056 spread: core24 testing infra snapcraft merged Merged PR #4056 as commit 1fee3d830, adding Spread test infrastructure for Ubuntu Core 24 (CRAFT-1639).
73%
#4621 chore(spread): enable pkg-repo tests for core24 snapcraft merged Merged PR #4621 (commit 57783b2c2), enabling core24 pkg-repo Spread tests and removing the redundant --use-lxd toggle because LXD was already the default.
73%
#924 chore(merge): hotfix/2.1 into main craft-parts closed Merged hotfix/2.1 into main through PR #924, carrying 10 changed files (+50/-16).
72%
#2417 fix: fix a series of breaking spread tests charmcraft merged Merged PR #2417 at commit 3bee888e, fixing multiple spread-test failures and unblocking the core24 migration; three listed tests remained broken but non-blocking.
72%