← Back to issue list

Fix spread tests

View original Github issue

Metadata

Project
imagecraft
Number
#127
Type
pull request
State
merged
Author
upils
Labels
Created
Updated
Closed

Current evaluation

Merged after receiving approval from two reviewers and passing all CI checks. The changes fix spread tests across 11 files (+49/-38 lines).

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after receiving approval from two reviewers and passing all CI checks. The changes fix spread tests across 11 files (+49/-38 lines).
qwen3.6-35b-a3b-mtp-q6 Merged by maintainer upils to fix failing spread tests. Changes were integrated into the main branch without additional review or requested modifications.
qwen3.6-35b-a3b-mtp-q6 Merged fix for failing spread tests. Changes were integrated into the main branch by maintainer upils, restoring test suite stability.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4529 Spread update snapcraft merged Merged after approval by two reviewers and passing CI checks. The update modifies spread configuration across three files, adding 36 and removing 40 lines. Code coverage tests passed.
86%
#13 test(spread): add more spread tests snapcraft-rocks merged Successfully merged spread tests covering architectures, chisel slices, craftctl, package-repositories, and patchelf. Approved by two reviewers across 15 files (+206/-5 lines).
83%
#1287 tests: minor cleanups on the spread tests snapcraft merged Merged minor spread test cleanups into master. Modified four files with 16 additions and 6 deletions. Approved by one reviewer with zero unresolved comments, maintaining 95.27% coverage upon integration.
82%
#3662 tests: update spread url snapcraft merged Merged update to spread tarball URLs in test files. Approved by a reviewer, passed CI checks, modified two files with minimal changes, and maintained existing code coverage.
82%
#534 test(spread): workaround for flaky test fetch-service merged Merged a workaround for a flaky spread test (issue #533). The change adjusts one file (+2/-1 lines) to skip a no-op name query check while retaining other validations. Approved by two reviewers and passed all CI checks.
81%
#1290 test(spread): clean up store tests charmcraft merged Merged cleanup of spread store tests, removing 28 lines across four files. The underlying library test failure is fixed in PR #1292. Approved by two reviewers.
80%
#2417 fix: fix a series of breaking spread tests charmcraft merged Merged after fixing multiple breaking spread tests. Commits resolve individual failures, while remaining broken tests are marked non-blocking for core24 migration. Approved by reviewers and merged following CI validation.
80%
#3432 spread tests: remove legacy plugin tests snapcraft merged Merged removal of legacy plugin tests from the spread test suite. Deleted 665 lines across 29 files. Approved by reviewer, passed CI, and maintained coverage. Unrelated test failures were addressed in a separate PR.
80%
#2032 ci: fixes to several weekly spread tests charmcraft merged Merged CI fixes for several weekly spread tests. Approved by two reviewers and passed all checks with minimal changes across three files. Addresses initial test failures as a starting point for broader improvements.
80%
#4924 tests: add spread tests for validation-sets snapcraft merged Merged changes adding spread tests for edit-validation-sets and list-validation-sets. Approved by two reviewers with passing CI, resolving issue #4918.
80%