← Back to issue list

tests: minor cleanups on the spread tests

View original Github issue

Metadata

Project
snapcraft
Number
#1287
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged into master as commit 1cf0f8c9f "tests: minor cleanups on the spread tests (#1287)" — a test-only tidy-up touching 4 spread test files (+16/-6), reviewed and approved by fgimenez, with coverage unchanged at 95.27%.

Resolution: closed resolved

Reason: The PR itself was merged into master, recorded as commit 1cf0f8c9f with the squashed title "tests: minor cleanups on the spread tests (#1287)". It was approved by a reviewer and contained only non-functional test cleanups, so no further follow-up was required.

Evaluated by: mr-cal-bot

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged into master as commit 1cf0f8c9f "tests: minor cleanups on the spread tests (#1287)" — a test-only tidy-up touching 4 spread test files (+16/-6), reviewed and approved by fgimenez, with coverage unchanged at 95.27%.
stealth/space-bunny-alpha — closed resolved Merged #1287 into master, cleaning up spread tests across four files (+16/−6) with coverage unchanged at 95.27%.
qwen/qwen3.6-35b-a3b — — Merged minor spread test cleanups into master. Modified four files with 16 additions and 6 deletions. Approved by one reviewer with zero unresolved comments, maintaining 95.27% coverage upon integration.
qwen3.6-35b-a3b-mtp-q6 — — Merged minor cleanup changes to spread tests into master. Coverage remains unchanged at 95.27%. Reviewer feedback was incorporated.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1290 test(spread): clean up store tests charmcraft merged Merged in commit 34ab4bdd, cleaning up store spread tests by deleting 28 lines across four files; the remaining library-test failure was fixed separately in #1292.
81%
#127 Fix spread tests imagecraft merged Fixed and merged as commit cd43de1, updating 11 files (+49/-38); all listed CI checks, including spread, passed.
80%
#1366 tests(spread): make release test less flaky charmcraft merged Merged #1366 at commit 05b18a03, reducing flakiness in the Spread release test and resolving #1362.
80%
#3432 spread tests: remove legacy plugin tests snapcraft merged PR #3432 (commit 950fa2508, f2c9caa04) merged: deleted 665 lines of legacy plugin spread tests across 29 files, removing outdated plugin coverage without affecting code coverage (90.83%).
78%
#1325 test(spread): consolidate basic init/build tests charmcraft merged Merged PR #1325 as commit 90e25caf, consolidating basic Spread init/build tests for CRAFT-2127 and reducing duplicated setup across four files.
78%
#4924 tests: add spread tests for validation-sets snapcraft merged Merged PR #4924 added spread coverage for edit-validation-sets and list-validation-sets, closing #4918; merge commit 157d0a182.
76%
#13 test(spread): add more spread tests snapcraft-rocks merged Merged PR #13 added Spread tests for architectures, Chisel slices, craftctl, package repositories, and patchelf (+206/-5 across 15 files).
76%
#3663 tests: update spread url snapcraft merged Merged via commit bcea80568, updating two Spread test tarball URLs (+2/-2 lines).
76%
#6202 test(spread): create core26 spread test suite snapcraft merged Merged PR #6202 as a9a5b4750, adding core26 Spread tests and CI coverage while generalizing common tests for core22, core24, and core26.
76%
#3662 tests: update spread url snapcraft merged Merged PR #3662 updated Spread tarball URLs in two test files via commit 507959d70.
75%