← Back to issue list

Fix grub install

View original Github issue

Metadata

Project
imagecraft
Number
#131
Type
pull request
State
merged
Author
upils
Labels
Created
Updated
Closed

Current evaluation

Merged a fix that skips GRUB installation when /boot/efi is missing, preventing packaging failures. Approved by reviewers and passed all CI checks.

Suggested action:

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? --- When trying to install GRUB, if `/boot/efi` mountpoint is missing the installation must be skipped (because it means the conditions to install GRUB are not met) but the packing must not fail.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix that skips GRUB installation when /boot/efi is missing, preventing packaging failures. Approved by reviewers and passed all CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged fix for GRUB installation that gracefully skips setup when the /boot/efi mountpoint is missing, preventing packing failures while correctly handling unmet installation conditions.
qwen3.6-35b-a3b-mtp-q6 Merged fix that skips GRUB installation when the /boot/efi mountpoint is absent, preventing packing failures while correctly handling unmet installation prerequisites.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#136 Test grub util imagecraft merged Merged after two approvals and CI verification. Adds tests for setup_grub(). Initial check failures were resolved, and the change was merged following the completion of dependent PR 135.
73%
#415 feat(grub): install EFI GRUB without loop devices imagecraft open PR converts EFI/GPT GRUB installation to use FUSE partition mounts instead of kernel loop devices, enabling unprivileged image builds. Has 11 unresolved review comments and some failing CI slow tests.
70%