← Back to issue list

Test grub util

View original Github issue

Metadata

Project
imagecraft
Number
#136
Type
pull request
State
merged
Author
upils
Labels
Created
Updated
Closed

Current evaluation

Merged after two approvals and CI verification. Adds tests for setup_grub(). Initial check failures were resolved, and the change was merged following the completion of dependent PR 135.

Suggested action:

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? --- Add tests for `setup_grub()`.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after two approvals and CI verification. Adds tests for setup_grub(). Initial check failures were resolved, and the change was merged following the completion of dependent PR 135.
qwen3.6-35b-a3b-mtp-q6 Added tests for setup_grub(). Merged after pull request #135.
qwen3.6-35b-a3b-mtp-q6 Merged after PR #135. Introduces unit tests for the setup_grub utility to validate GRUB configuration generation and ensure reliable boot setup.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#131 Fix grub install imagecraft merged Merged a fix that skips GRUB installation when /boot/efi is missing, preventing packaging failures. Approved by reviewers and passed all CI checks.
73%
#410 build: install grub/ext4/blkid tooling in `make setup` imagecraft merged Merged to add grub-common, e2fsprogs, and util-linux to make setup. This resolves unit test failures by installing missing GRUB tooling, enabling rootless test execution. Approved by reviewers with passing CI.
72%