← Back to issue list

docs: clean up 'imagecraft.yaml'

View original Github issue

Metadata

Project
imagecraft
Number
#189
Type
pull request
State
merged
Author
jahn-junior
Labels
—
Created
Updated
Closed

Current evaluation

Merged in bfe4f70: updated pydantic-kitbash to v0.0.7, removed library modules from sys.path, and added currentmodule directives to clean up the imagecraft.yaml docs.

Resolution: closed resolved

Reason: PR imagecraft#189 was approved and merged as commit bfe4f70, resolving the documentation cleanup and future Kitbash warnings.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you followed the guidelines for contributing? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint && make test`? --- * Update `pydantic-kitbash` to v0.0.7 * Remove library modules from `sys.path` * Clean up 'Part Properties' by declaring ..py:currentmodule:: Once Imagecraft is updated to the next Craft Parts release, this will get rid of the Kitbash warnings in docs builds.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in bfe4f70: updated pydantic-kitbash to v0.0.7, removed library modules from sys.path, and added currentmodule directives to clean up the imagecraft.yaml docs.
stealth/space-bunny-alpha — closed resolved Merged in bfe4f70 (#189): updated pydantic-kitbash to v0.0.7, removed library modules from sys.path, and added currentmodule directives to clean up imagecraft.yaml docs.
qwen/qwen3.6-35b-a3b — — Merged documentation cleanup for imagecraft.yaml. Updated pydantic-kitbash to v0.0.7, removed library modules from sys.path, and added currentmodule directives to eliminate Kitbash warnings. Approved and passed CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged documentation cleanup that updates pydantic-kitbash to v0.0.7, removes library modules from sys.path, and fixes module declarations to eliminate Kitbash warnings in docs builds.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#245 docs: clean up 'imagecraft.yaml' imagecraft merged Merged as 3f819e5: upgraded pydantic-kitbash to v0.1.1, removed legacy workarounds, and cleaned up typos and language in the imagecraft.yaml documentation.
94%
#259 docs: incorporate Kitbash 1.0 imagecraft merged Merged as canonical/imagecraft#259 (commit b1d6658): bumped pydantic-kitbash to v1.0 (new kitbash-field directives) and renamed imagecraft-yaml-file.rst to imagecraft-yaml.rst. Snap build failure was noted as unrelated.
81%
#5665 docs: clean up 'snapcraft.yaml' snapcraft merged Merged docs cleanup in #5665 (30ab2b049): upgraded pydantic-kitbash to 0.0.7, removed library modules from sys.path, and declared currentmodule for Part Properties.
80%
#173 docs: update 'imagecraft.yaml' imagecraft merged Merged the imagecraft.yaml documentation update, reordering part keys and documenting organize, in PR #173 (commit d46f752).
74%
#156 docs: update yaml reference imagecraft merged Merged PR #156 as commit 1dbd410, automating the imagecraft.yaml reference with Kitbash and field docstrings added in PR #153.
71%
#5924 docs: clean up 'snapcraft.yaml' snapcraft merged Merged snapcraft.yaml documentation cleanup in #5924 via commit 83f961ebc, upgrading pydantic-kitbash, correcting docstrings and links, and regenerating the JSON schema.
71%