← Back to issue list

docs: incorporate Kitbash 1.0

View original Github issue

Metadata

Project
imagecraft
Number
#259
Type
pull request
State
merged
Author
jahn-junior
Labels
—
Created
Updated
Closed

Current evaluation

Merged as canonical/imagecraft#259 (commit b1d6658): bumped pydantic-kitbash to v1.0 (new kitbash-field directives) and renamed imagecraft-yaml-file.rst to imagecraft-yaml.rst. Snap build failure was noted as unrelated.

Resolution: closed resolved

Reason: PR #259 was approved by three reviewers and merged as commit b1d6658 ("docs: incorporate Kitbash 1.0 (#259)"). It upgraded pydantic-kitbash to v1.0 and renamed the docs page to imagecraft-yaml.rst, which still uses kitbash-field directives; pyproject.toml now pins pydantic-kitbash>=1.0.1,<2.0.

Evaluated by: mr-cal-bot

No scores available.

Issue body

* Upgrade pydantic-kitbash to v1.0 * Rename imagecraft-yaml-file.rst to imagecraft-yaml.rst There were no refs using the old label format, but I figure it's better to update before any new ones are created. --- - [X] I've followed the [contribution guidelines](https://github.com/canonical/imagecraft/blob/main/CONTRIBUTING.md). - [X] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). ~~I've successfully run `make lint && make test`~~ ~~I've added or updated any relevant documentation.~~

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as canonical/imagecraft#259 (commit b1d6658): bumped pydantic-kitbash to v1.0 (new kitbash-field directives) and renamed imagecraft-yaml-file.rst to imagecraft-yaml.rst. Snap build failure was noted as unrelated.
stealth/space-bunny-alpha — closed resolved Merged in canonical/imagecraft#259 (b1d6658): upgraded pydantic-kitbash to v1.0 and renamed the Imagecraft YAML reference page.
stealth/space-bunny-alpha — closed resolved Merged PR #259 (commit b1d6658) upgraded pydantic-kitbash to v1.0 and renamed imagecraft-yaml-file.rst to imagecraft-yaml.rst. The reported snap build failure was unrelated.
qwen/qwen3.6-35b-a3b — — Merged documentation update upgrading pydantic-kitbash to v1.0 and renaming the YAML reference file. Approved by three reviewers with passing CI checks. An unrelated snap build failure was noted but did not prevent the merge.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Upgraded pydantic-kitbash to v1.0 and renamed imagecraft-yaml-file.rst to imagecraft-yaml.rst to standardize documentation references. Unrelated snap build failure noted but did not prevent merge.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/imagecraft#293 (confidence 40%)

    Later docs commit reordering the imagecraft.yaml reference page touched the same renamed file.

Related issues

Issue Project State Summary Similarity
#245 docs: clean up 'imagecraft.yaml' imagecraft merged Merged as 3f819e5: upgraded pydantic-kitbash to v0.1.1, removed legacy workarounds, and cleaned up typos and language in the imagecraft.yaml documentation.
83%
#189 docs: clean up 'imagecraft.yaml' imagecraft merged Merged in bfe4f70: updated pydantic-kitbash to v0.0.7, removed library modules from sys.path, and added currentmodule directives to clean up the imagecraft.yaml docs.
81%
#1075 docs: incorporate pydantic-kitbash 1.0.0 rockcraft merged Merged #1075 in 9ad107a0, upgrading pydantic-kitbash to 1.0.0 and updating YAML key references to its collision-safe label format.
77%
#5972 docs: incorporate pydantic-kitbash 1.0.0 snapcraft merged Merged PR #5972 in commit f441d1d64, updating pydantic-kitbash docs to 1.0.0, removing redundant label overrides, and revising YAML-key references.
74%
#156 docs: update yaml reference imagecraft merged Merged PR #156 as commit 1dbd410, automating the imagecraft.yaml reference with Kitbash and field docstrings added in PR #153.
73%
#5665 docs: clean up 'snapcraft.yaml' snapcraft merged Merged docs cleanup in #5665 (30ab2b049): upgraded pydantic-kitbash to 0.0.7, removed library modules from sys.path, and declared currentmodule for Part Properties.
70%