← Back to issue list

chore: change mount calls to use pathlib

View original Github issue

Metadata

Project
imagecraft
Number
#272
Type
pull request
State
open
Author
EdmilsonRodrigues
Labels
Created
Updated
Closed

Current evaluation

Chore PR adapting imagecraft's craft-parts mount/umount calls to the new pathlib-based API (craft-parts#1424). +18/-18 across 2 files. Pending, 0 reviewers, 0 comments, no CI; dormant 166 days.

Suggested action: needs review

Reason: Main branch still calls the old craft_parts os_utils.mount/umount API (imagecraft/pack/chroot.py:86,95,103), so the adaptation is not yet applied and the change remains potentially relevant. However, with 0 comments, 0 reviewers, no CI, and 166 days of inactivity, it needs a maintainer to confirm whether the craft-parts#1424 API change is in the pinned dependency before it can be judged mergeable or stale.

Impact: 25 Quick Win: 20.0 Staleness: 62 Complexity: 20 Confidence: 55

Issue body

Adjust calls to functions of craft-parts to use pathlib after [change in craft-parts API](https://github.com/canonical/craft-parts/pull/1424). --- - [X] I've followed the [contribution guidelines](https://github.com/canonical/imagecraft/blob/main/CONTRIBUTING.md). - [X] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [X] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 25
Quick Win: 20.0
Staleness: 62
Complexity: 20
Confidence: 55
needs review Chore PR adapting imagecraft's craft-parts mount/umount calls to the new pathlib-based API (craft-parts#1424). +18/-18 across 2 files. Pending, 0 reviewers, 0 comments, no CI; dormant 166 days.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 15
Confidence: 75
close stale Updates craft-parts mount calls to use pathlib following upstream API changes. Currently pending review with no CI checks or comments after 125 days of inactivity.
qwen3.6-35b-a3b-mtp-q6
Staleness: 50
Complexity: 15
Confidence: 90
needs review Adapts craft-parts mount calls to use pathlib following an upstream API change. PR is ready with lint/tests passing but has been inactive for over three months awaiting maintainer review.
qwen3.6-35b-a3b-mtp-q6
Staleness: 55
Complexity: 20
Confidence: 70
needs review Adapts craft-parts mount calls to use pathlib following an upstream API change. Author reports lint and tests pass, but there is no maintainer feedback or CI status after 108 days of inactivity.
qwen3.6-35b-a3b-mtp-q6
Staleness: 65
Complexity: 15
Confidence: 75
needs review Updates mount calls to use pathlib following a craft-parts API change. The PR is open, lacks labels and comments, and has been inactive for 89 days. Linting and tests pass, but documentation updates are pending. Awaiting triage or maintainer review.

Update history

No update history recorded yet.

Related work

  • Related To: rockcraft#1081 (confidence 70%)

    Sibling rockcraft PR making the same pathlib adaptation to craft-parts; indicates a cross-project API migration pattern.

Related issues

Issue Project State Summary Similarity
#1081 chore: use pathlib to interact with craft-parts rockcraft open Adapts craft-parts API calls to use pathlib after upstream craft-parts#1424. 217 days old, zero comments/reviews. Same change already landed in main via commit 1406be57 'refactor: update for Path change in craft-parts'.
82%
#5981 chore: use pathlib to interact with craft-parts snapcraft open Adapts craft-parts API calls to use pathlib after upstream craft-parts#1424 (2.33 release). 217 days old, 0 comments, 0 reviewers, 4 unresolved review comments, several CI checks failing. Main already requires craft-parts>=2.33.0.
80%
#621 chore: update fileset and organize docstrings craft-parts merged Merged a chore pull request updating the fileset and organizing docstrings. Changes affected two files (+22/-9 lines). Approved by two reviewers, passed CI checks, and was successfully merged by the maintainer.
71%
#498 chore: remove comment fences from GitHub templates starbase merged Merged upstream changes removing comment fences from GitHub templates. Approved by two reviewers with all CI checks passing. Updated one file to align with canonical/imagecraft and canonical/snapcraft.
71%