← Back to issue list

chore: change type checking to use `ty`

View original Github issue

Metadata

Project
imagecraft
Number
#328
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Switched type checking to ty, resolving issue 263. Merged after two approvals and passing CI checks. Changes span three files with minimal code adjustments.

Suggested action:

No scores available.

Issue body

Fixes #263 --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/imagecraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Switched type checking to ty, resolving issue 263. Merged after two approvals and passing CI checks. Changes span three files with minimal code adjustments.
qwen3.6-35b-a3b-mtp-q6 Merged a maintainer's change to switch the project's type checking tool to ty, resolving issue #263. The update passed all lint and test checks before integration.
qwen3.6-35b-a3b-mtp-q6 Merged a maintainer pull request that switches the project's type checking tool to ty, resolving issue 263. The update passed all lint and test checks before integration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#369 chore: fix linting imagecraft merged Merged after resolving redundant casting linting errors flagged by Ty. Approved by two reviewers. Changes involved minimal edits (+2/-2 lines) across one file. CI lint and test checks passed prior to merge.
80%
#557 chore(deps): update type checkers craft-parts merged Updating type checker dependencies was approved by two reviewers, passed CI checks, and successfully merged into the repository.
78%
#1099 chore: fix linting craft-application merged Merged a linting fix to resolve unused directives flagged by Ty. The update modified two files, received approval from two reviewers, passed CI validation, and was successfully integrated.
78%
#2726 style: switch type checking to ty charmcraft merged Merged after switching type checking to the ty tool. Resolves existing ty issues, approved by two reviewers, passed CI checks, and modified 40 files.
77%
#1764 chore: add typing to env.py charmcraft merged Merged a chore update adding type annotations to env.py. The change modified two files (+14/-13 lines), received approval from two reviewers, and passed all checks without unresolved comments.
75%
#181 chore(lint): add new typing dependencies and fix pyright issues craft-cli merged Merged into main following approval. The update adds typing dependencies and resolves pyright type errors across a single file. All CI checks passed, and code coverage remained stable during integration.
74%
#407 style(types): enable type checking with ty craft-cli merged Merged pull request enabling type checking with ty. Approved by two reviewers with all CI checks passing. Changes add 21 lines and remove 3 across three files, successfully implementing the requested type checking improvements.
74%
#128 chore: skip typing checkers in "_version.py" starbase merged Merged a chore to skip typing checkers in _version.py. Approved by two reviewers and passed all CI checks. The change adds seven lines with zero coverage impact, serving as an upstream dependency for related repositories.
74%
#907 chore(merge): 2.1.3 into main craft-parts merged Merged version 2.1.3 into main following approval from two reviewers and passing CI checks. The change updated seven files, adding 36 lines and removing 10.
73%
#2444 chore: clean up unused/unnecessary files charmcraft merged Merged a chore change removing 286 lines across 10 unused files. Approved by two reviewers and integrated despite non-blocking macOS test failures and type checker warnings.
72%