← Back to issue list

style: switch type checking to ty

View original Github issue

Metadata

Project
charmcraft
Number
#2726
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

PR #2726 merged as commit f2e05e81, switching Charmcraft type checking to Astral ty and fixing existing ty errors.

Resolution: closed resolved

Reason: Merged PR canonical/charmcraft#2726 landed as commit f2e05e81. It replaced the previous type-checking setup with ty and addressed all extant ty findings.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This changes all of the type checking to use ty, fixing all the extant ty issues along the way. --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/charmcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #2726 merged as commit f2e05e81, switching Charmcraft type checking to Astral ty and fixing existing ty errors.
stealth/space-bunny-alpha — closed resolved Merged PR #2726 switched Charmcraft's type checking from mypy to ty and fixed existing ty errors in commit f2e05e81.
stealth/space-bunny-alpha — closed resolved Merged PR #2726 in commit f2e05e81, switching Charmcraft’s type checking to ty and fixing existing ty errors.
qwen/qwen3.6-35b-a3b — — Merged after switching type checking to the ty tool. Resolves existing ty issues, approved by two reviewers, passed CI checks, and modified 40 files.
qwen3.6-35b-a3b-mtp-q6 — — Merged the migration to the ty type checker, resolving all pre-existing ty issues. The maintainer updated the configuration and verified the changes passed lint and test suites.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#472 style: enable ty by default starbase merged Merged PR #472 as commit 7982765, making Astral ty a default type-checking option while retaining existing checkers.
78%
#139 style(type): fix typing issues found by ty craft-platforms merged Merged as commit 1a30eec, fixing type-checking edge cases found by ty; the remaining diagnostic was an upstream false positive tracked in astral-sh/ty#553.
77%
#328 chore: change type checking to use `ty` imagecraft merged PR #328 merged as fc21f39, changing Imagecraft's type checking to Astral ty and resolving #263.
72%