← Back to issue list

feat(Project): add MBR and hybrid volume schemas

View original Github issue

Metadata

Project
imagecraft
Number
#329
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged. Adds acceptance of MBR and hybrid (MBR+GPT) volume schemas in projects without full implementation. Approved by reviewers and passed all CI checks.

Suggested action:

No scores available.

Issue body

This adds the ability to accept projects with `mbr` and `mbr,gpt` (hybrid) volume schemas. We don't implement this currently, we just accept projects that have it. IMAGECRAFT-111 --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/imagecraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation. - [x] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Adds acceptance of MBR and hybrid (MBR+GPT) volume schemas in projects without full implementation. Approved by reviewers and passed all CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged. Adds project validation to accept MBR and hybrid MBR+GPT volume schemas without full implementation, addressing IMAGECRAFT-111.
qwen3.6-35b-a3b-mtp-q6 Merged changes allow accepting projects with MBR and hybrid MBR+GPT volume schemas. Implementation is deferred; the update only validates and permits these configurations. Resolves IMAGECRAFT-111.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#359 docs: describe MBR and hybrid schemas imagecraft merged Merged documentation describing MBR and MBR/GPT hybrid schemas. Approved by two reviewers and passed all CI checks. Linting flags for master boot record were resolved using Sphinx vale-ignore syntax.
78%
#338 feat: add support for MBR images imagecraft merged Merged implementation adding MBR image support for x86 systems via GRUB installation. Approved by two reviewers and passed CI checks following resolution of initial lint and copilot failures.
71%
#286 feat(volumes): add some more GPT types imagecraft merged Merged addition of extra GPT partition types to volumes. Approved with all CI checks passing. Implemented as a temporary testing workaround and expected to be superseded by PRs #276 and #285.
71%