feat(Project): add MBR and hybrid volume schemas
Metadata
Current evaluation
Merged PR #329 as commit 805f640, adding acceptance of mbr and mbr,gpt hybrid volume schemas; the schemas were not yet implemented.
Resolution: closed resolved
Reason: The approved PR passed all CI checks and was merged as commit 805f640. It updated project validation, tests, and documentation to accept MBR and hybrid volume schemas.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This adds the ability to accept projects with `mbr` and `mbr,gpt` (hybrid) volume schemas. We don't implement this currently, we just accept projects that have it.
IMAGECRAFT-111
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/imagecraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [x] I've added or updated any relevant documentation.
- [x] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #329 as commit 805f640, adding acceptance of mbr and mbr,gpt hybrid volume schemas; the schemas were not yet implemented. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR canonical/imagecraft#329 (commit 805f640) adds acceptance of `mbr` and hybrid `mbr,gpt` project volume schemas; closes tracking issue #310 (IMAGECRAFT-111). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/imagecraft#329 (805f640), adding acceptance of mbr and mbr,gpt (hybrid) project volume schemas without implementing those schemas. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #329 (805f640), adding validation to accept mbr and hybrid mbr,gpt volume schemas without implementing support for them. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #329 (commit 805f640), adding acceptance and validation of MBR and hybrid mbr,gpt project volume schemas without implementing partitioning. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Adds acceptance of MBR and hybrid (MBR+GPT) volume schemas in projects without full implementation. Approved by reviewers and passed all CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Adds project validation to accept MBR and hybrid MBR+GPT volume schemas without full implementation, addressing IMAGECRAFT-111. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/imagecraft#359
(confidence 98%)
Follow-up PR #359 documented the MBR and MBR/GPT hybrid schemas introduced here.
-
Likely Fixed By:
canonical/imagecraft#310
(confidence 88%)
The MBR image support issue was closed as addressed by PR #329, although this PR only added schema acceptance.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #310 Support creating MBR images | imagecraft | closed | MBR image support delivered: PR #329 (commit 805f640) added mbr/hybrid mbr,gpt volume schemas, PR #338 (47fd939) implemented actual MBR layout plus BIOS/GRUB boot support; closed by maintainer steinbro ("Done via #329"). | |
| #359 docs: describe MBR and hybrid schemas | imagecraft | merged | Merged canonical/imagecraft#359 as commit 04f04c6, documenting MBR and MBR/GPT hybrid schemas, partition fields, and YAML examples. |