← Back to issue list

Support creating MBR images

View original Github issue

Metadata

Project
imagecraft
Number
#310
Type
issue
State
closed
Author
dilyn-corner
Labels
Status: Triaged Type: Enhancement
Created
Updated
Closed

Current evaluation

MBR image support delivered: PR #329 (commit 805f640) added mbr/hybrid mbr,gpt volume schemas, PR #338 (47fd939) implemented actual MBR layout plus BIOS/GRUB boot support; closed by maintainer steinbro ("Done via #329").

Resolution: closed resolved

Reason: The enhancement request was implemented: PR #329 merged as commit 805f640 to accept 'mbr' and 'mbr,gpt' volume schemas, followed by PR #338 (commit 47fd939) adding the actual MBR layout code (imagecraft/pack/mbrutil.py, sfdisk-based) and BIOS bootloader support, with docs added in #359. Maintainer steinbro closed the issue citing #329; internal ticket IMAGECRAFT-111.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### Check existing issues - [x] I've verified that this request isn't described by any existing issues. ### Request Describe the feature you'd like to see implemented. Currently imagecraft only supports GPT partition tables, and even then only a limited number of GUIDs. Imagecraft should allow `schema: mbr|gpt` and create the right disk image accordingly. ### The problem it solves Describe the impact your request would have. Some systems do not support GPT. This is true for both Ubuntu Core and Ubuntu Classic images.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved MBR image support delivered: PR #329 (commit 805f640) added mbr/hybrid mbr,gpt volume schemas, PR #338 (47fd939) implemented actual MBR layout plus BIOS/GRUB boot support; closed by maintainer steinbro ("Done via #329").
stealth/space-bunny-alpha — closed resolved MBR image support was completed in merged PR canonical/imagecraft#329 (805f640), adding mbr and hybrid mbr,gpt volume schemas.
stealth/space-bunny-alpha — closed resolved Implemented MBR image support via merged PR #329 (805f640), adding acceptance of mbr and mbr,gpt (hybrid) volume schemas. The maintainer closed the request as done.
qwen/qwen3.6-35b-a3b — — Added MBR partition table support alongside GPT. The enhancement was implemented and merged via pull request #329.
qwen/qwen3.6-35b-a3b
Staleness: 55
Complexity: 45
Confidence: 80
Support Request: 5
keep open Feature request to add MBR partition table support to imagecraft alongside existing GPT support. Currently triaged and awaiting implementation.
qwen3.6-35b-a3b-mtp-q6
Staleness: 55
Complexity: 45
Confidence: 75
Support Request: 10
keep open Enhancement request to add MBR partition table support alongside existing GPT support. The issue is triaged and awaiting implementation or further discussion.
qwen3.6-35b-a3b-mtp-q6
Staleness: 55
Complexity: 45
Confidence: 85
Support Request: 10
keep open Feature request to add MBR partition table support to imagecraft alongside existing GPT support. Triaged and linked to internal Jira ticket, awaiting implementation.

Update history

Date Change
closed

Related work

  • Likely Fixed By: canonical/imagecraft#329 (confidence 95%)

    Cited in the closing comment; merged as 805f640, added mbr and mbr,gpt volume schemas (imagecraft/models/volume.py).

  • Likely Fixed By: canonical/imagecraft#338 (confidence 92%)

    Merged as 47fd939; implemented MBR layout creation (pack/mbrutil.py, services/image.py) and BIOS/GRUB MBR boot support.

  • Related To: canonical/imagecraft#359 (confidence 80%)

    Merged docs describing MBR and hybrid mbr,gpt schemas in docs/reference/imagecraft-yaml.rst.

Related issues

Issue Project State Summary Similarity
#338 feat: add support for MBR images imagecraft merged MBR image support was merged via canonical/imagecraft#338, commit 47fd939, including GRUB installation for MBR images on x86 systems.
78%
#329 feat(Project): add MBR and hybrid volume schemas imagecraft merged Merged PR #329 as commit 805f640, adding acceptance of mbr and mbr,gpt hybrid volume schemas; the schemas were not yet implemented.
76%