← Back to issue list

feat: add support for MBR images

View original Github issue

Metadata

Project
imagecraft
Number
#338
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

MBR image support was merged via canonical/imagecraft#338, commit 47fd939, including GRUB installation for MBR images on x86 systems.

Resolution: closed resolved

Reason: PR #338 was approved and merged into the main project as commit 47fd939, adding MBR image support and GRUB installation for x86 systems.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This includes installing grub on MBR images on x86 systems. This is the only MBR system for which grub has a target — everything else is efi, u-boot, or coreboot. IMAGECRAFT-137 --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/imagecraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved MBR image support was merged via canonical/imagecraft#338, commit 47fd939, including GRUB installation for MBR images on x86 systems.
stealth/space-bunny-alpha — closed resolved Merged MBR image support in #338 (47fd939), including GRUB installation for MBR images on x86, the only MBR platform supported by GRUB.
stealth/space-bunny-alpha — closed resolved Merged PR #338 (commit 47fd939), adding MBR image support on x86 systems by installing GRUB, the only MBR platform with a GRUB target.
qwen/qwen3.6-35b-a3b — — Merged implementation adding MBR image support for x86 systems via GRUB installation. Approved by two reviewers and passed CI checks following resolution of initial lint and copilot failures.
qwen3.6-35b-a3b-mtp-q6 — — Merged to add MBR image support by installing GRUB on x86 systems. Resolves IMAGECRAFT-137. No additional comments or documentation updates were required.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#310 Support creating MBR images imagecraft closed MBR image support delivered: PR #329 (commit 805f640) added mbr/hybrid mbr,gpt volume schemas, PR #338 (47fd939) implemented actual MBR layout plus BIOS/GRUB boot support; closed by maintainer steinbro ("Done via #329").
78%