feat: add support for MBR images
Metadata
Current evaluation
Merged implementation adding MBR image support for x86 systems via GRUB installation. Approved by two reviewers and passed CI checks following resolution of initial lint and copilot failures.
Suggested action: —
No scores available.
Issue body
This includes installing grub on MBR images on x86 systems. This is the
only MBR system for which grub has a target — everything else is efi,
u-boot, or coreboot.
IMAGECRAFT-137
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/imagecraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged implementation adding MBR image support for x86 systems via GRUB installation. Approved by two reviewers and passed CI checks following resolution of initial lint and copilot failures. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to add MBR image support by installing GRUB on x86 systems. Resolves IMAGECRAFT-137. No additional comments or documentation updates were required. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Successfully merged feature adding MBR image support by installing GRUB on x86 systems. Resolves IMAGECRAFT-137. Implementation passed all lint and test checks before integration. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #310 Support creating MBR images | imagecraft | closed | Added MBR partition table support alongside GPT. The enhancement was implemented and merged via pull request #329. | |
| #329 feat(Project): add MBR and hybrid volume schemas | imagecraft | merged | Merged. Adds acceptance of MBR and hybrid (MBR+GPT) volume schemas in projects without full implementation. Approved by reviewers and passed all CI checks. |