← Back to issue list

No loops for grub

View original Github issue

Metadata

Project
imagecraft
Number
#348
Type
pull request
State
closed
Author
mwhudson
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged and superseded by #437, merged as 0ca6f6e, which introduced zero-mount bootloader installation without loop devices.

Resolution: closed superseded

Reason: The loopless GRUB proposal was not merged through #348. Later, #437 delivered the equivalent zero-mount bootloader installation in commit 0ca6f6e.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Part 2 of my "no loop device" effort --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/imagecraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged and superseded by #437, merged as 0ca6f6e, which introduced zero-mount bootloader installation without loop devices.
stealth/space-bunny-alpha — closed stale Closed unmerged with no CI, completed checklist, or recorded resolution; review remained pending after the author’s last commit.
stealth/space-bunny-alpha
Impact: 55
Quick Win: 7
Complexity: 74
Confidence: 66
Actionability: 48
needs review Reworks GRUB installation to avoid loop devices across seven files; awaiting maintainer review, with no CI checks and the test and CLA checklist unfinished.
qwen3.6-35b-a3b-mtp-q6
Impact: 50
Quick Win: 20
Staleness: 75
Complexity: 60
Confidence: 65
needs review Refactors grub handling to avoid loop devices, replacing special handling with a more generic approach. Stalled for 100 days pending maintainer feedback on architectural direction.
qwen/qwen3.6-35b-a3b
Staleness: 55
Complexity: 60
Confidence: 70
needs review Removes loop device usage for grub image assembly, changing 7 files. Currently pending maintainer review after 56 days of inactivity and unresolved architectural questions.
qwen3.6-35b-a3b-mtp-q6
Staleness: 45
Complexity: 40
Confidence: 85
needs review Refactors grub handling to eliminate loop device usage, part of a broader cleanup effort. Currently under discussion after maintainer feedback on plugin architecture; author pushed a follow-up commit but activity has paused for 44 days.

Update history

Date Change
closed

Related work

  • Superseded By: canonical/imagecraft#437 (confidence 96%)

    Its merged implementation stages bootloader files directly and avoids loop devices.

Related issues

Issue Project State Summary Similarity
#434 feat(grub): loop-device-free EFI GRUB setup imagecraft closed Closed unmerged and superseded by #437, which merged the broader zero-mount bootloader installer in commit 0ca6f6e.
84%
#416 feat(grub): install BIOS GRUB without loop devices or chroot imagecraft closed Closed unmerged after inactivity; its zero-mount GRUB goal was superseded by merged #437 (commit 0ca6f6e), which replaced loop-device and chroot installation.
79%
#415 feat(grub): install EFI GRUB without loop devices imagecraft closed Closed after its EFI/GPT work was superseded by #437, which merged the broader zero-mount bootloader installer in commit 0ca6f6e.
77%