← Back to issue list

feat(grub): loop-device-free EFI GRUB setup

View original Github issue

Metadata

Project
imagecraft
Number
#434
Type
pull request
State
closed
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged and superseded by #437, which merged the broader zero-mount bootloader installer in commit 0ca6f6e.

Resolution: closed superseded

Reason: #434 was replaced by the broader implementation in merged PR #437. That PR delivered zero-mount bootloader installation in commit 0ca6f6e, while #434 remained unmerged with 17 unresolved review comments and failing CI.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Describe your changes. --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/imagecraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged and superseded by #437, which merged the broader zero-mount bootloader installer in commit 0ca6f6e.
qwen/qwen3.8-27b — closed superseded PR #434 for loop-device-free EFI GRUB setup was closed unmerged after 26 days with 17 unresolved review comments and failing CI. Superseded by PR #437 (commit 0ca6f6e) implementing zero-mount bootloader installation.
qwen/qwen3.8-27b — closed superseded PR #434 (loop-device-free EFI GRUB setup) was closed unmerged after ~28 days with 17 unresolved review comments and failing spread/build checks. The approach was superseded by merged PR #437 (zero-mount bootloader installation), which replaced the loop-device+chroot GRUB install with a zero-mount installer.
stealth/space-bunny-alpha — closed stale PR #434 implementing loop-device-free EFI GRUB setup was closed unmerged after 26 days of inactivity, with seven unresolved review comments and several checks pending.
stealth/space-bunny-alpha
Impact: 55
Quick Win: 4
Complexity: 80
Confidence: 84
Actionability: 38
keep open Implements loop-device-free EFI GRUB setup as part of a GRUB refactoring stack. Core tests and security scans pass, but seven review comments remain unresolved and builds plus root and slow tests are pending.
qwen3.6-35b-a3b-mtp-q6
Impact: 55
Quick Win: 19
Staleness: 10
Complexity: 65
Confidence: 75
needs review Part of a GRUB refactoring stack implementing loop-device-free EFI GRUB setup. Fresh PR with 7 unresolved review comments and no maintainer engagement yet.

Update history

Date Change
updated
closed
updated
updated
updated
updated
updated
updated
updated
updated
created

Related work

  • Superseded By: canonical/imagecraft#437 (confidence 99%)

    Its merged zero-mount bootloader installer replaced #434's narrower EFI GRUB approach.

  • Duplicate Of: canonical/imagecraft#415 (confidence 74%)

    Earlier loop-device-free EFI GRUB work was also superseded by #437.

Related issues

Issue Project State Summary Similarity
#415 feat(grub): install EFI GRUB without loop devices imagecraft closed Closed after its EFI/GPT work was superseded by #437, which merged the broader zero-mount bootloader installer in commit 0ca6f6e.
92%
#416 feat(grub): install BIOS GRUB without loop devices or chroot imagecraft closed Closed unmerged after inactivity; its zero-mount GRUB goal was superseded by merged #437 (commit 0ca6f6e), which replaced loop-device and chroot installation.
85%
#348 No loops for grub imagecraft closed Closed unmerged and superseded by #437, merged as 0ca6f6e, which introduced zero-mount bootloader installation without loop devices.
84%
#437 feat: zero-mount bootloader installation imagecraft merged Merged to main (commit 0ca6f6e). Replaces privileged loop-device+chroot GRUB install (pack/grubutil.py) with a zero-mount bootloader package staging files into prime dirs; +3415/-1275 across 31 files.
73%