CI: zizmor flags unpinned GitHub Actions in check-renovate.yaml / release-publish.yaml
Metadata
Current evaluation
Resolved in #585: actions pinned to commit SHAs in check-renovate.yaml and release-publish.yaml; softprops/action-gh-release replaced with gh release create.
Resolution: closed resolved
Reason: PR #585 (commit f86068e) pinned all GitHub Actions to commit SHAs and replaced softprops/action-gh-release with gh release create, eliminating the zizmor unpinned-uses and superfluous-actions findings.
Evaluated by: mr-cal-bot
No scores available.
Issue body
🤖 [BEEP BOOP, A BOT WROTE THIS COMMENT - Claude Sonnet 5, GitHub Copilot CLI]
The repository's `zizmor` code-scanning check flags several `unpinned-uses` findings (actions referenced by tag instead of commit hash) in two starbase-owned workflow files:
- `.github/workflows/check-renovate.yaml` (`actions/checkout`, `actions/setup-node`, `mxschmitt/action-tmate`)
- `.github/workflows/release-publish.yaml` (`softprops/action-gh-release`, plus a `superfluous-actions` note that `gh release` could replace it)
These findings are **pre-existing on `main`** (confirmed by running `zizmor` locally against `origin/main` before any starbase-merge changes — the same actions were already unpinned, just at older version tags). They surfaced as new PR annotations in [#402](https://github.com/canonical/imagecraft/pull/402) only because that PR bumped the action versions (e.g. `actions/checkout@v6` → `@v7`), which caused `zizmor`'s "new alerts in changed code" heuristic to flag the already-unpinned lines.
Since both files are owned by `starbase` (Canonical's shared craft-tool scaffolding) rather than `imagecraft` itself, the long-term fix (hash-pinning these actions, or excluding/allow-listing them) likely belongs upstream in `canonical/starbase` so all consuming repos benefit. Tracking here so it isn't lost, and so future `update-starbase` merge PRs aren't blocked/confused by it.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| ~deepseek/deepseek-pro-latest | — | closed resolved | Resolved in #585: actions pinned to commit SHAs in check-renovate.yaml and release-publish.yaml; softprops/action-gh-release replaced with gh release create. | |
| stealth/space-bunny-alpha |
Impact:
25
Quick Win:
13
Complexity:
35
Confidence:
58
Actionability:
80
|
needs triage | Tracks zizmor unpinned-uses findings in starbase-owned check-renovate.yaml and release-publish.yaml; pre-existing, non-blocking annotations. Bot-filed, unlabelled, no maintainer response; fix may belong upstream in canonical/starbase. | |
| qwen/qwen3.8-27b |
Impact:
30
Quick Win:
20
Complexity:
20
Confidence:
90
Actionability:
85
|
close resolved | Tracks zizmor unpinned-uses findings in starbase-owned check-renovate.yaml and release-publish.yaml workflows. Resolved by commit f86068e (PR #585), which hash-pinned all actions and replaced softprops/action-gh-release with gh release. | |
| stealth/space-bunny-alpha |
Impact:
32
Quick Win:
22
Complexity:
15
Confidence:
93
Actionability:
82
|
close resolved | Bot-tracked zizmor unpinned-uses findings in starbase-owned check-renovate.yaml/release-publish.yaml; since fixed by #585, which pins all actions to SHAs and drops softprops/action-gh-release for gh release. | |
| stealth/space-bunny-alpha |
Impact:
30
Quick Win:
20
Complexity:
20
Confidence:
90
Actionability:
85
|
needs triage | Preexisting zizmor unpinned-uses findings in two starbase-owned workflows surfaced by #402; no labels or follow-up activity yet. | |
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
40
Quick Win:
32
Staleness:
45
Complexity:
20
Confidence:
60
Support Request:
0
|
needs triage | Tracking issue for zizmor flags on unpinned GitHub Actions in starbase-owned workflow files; awaiting triage | |
| qwen/qwen3.6-35b-a3b |
Staleness:
0
Complexity:
10
Confidence:
90
Support Request:
0
|
needs triage | CI scan flags unpinned GitHub Actions in two workflow files. Findings are pre-existing and owned by an upstream repository. Currently unlabelled and awaiting maintainer triage to decide between upstream fix or local allow-list. |
Update history
| Date | Change |
|---|---|
| closed | |
| created |
Related work
-
Likely Fixed By:
imagecraft#585
(confidence 100%)
Commit f86068e modified both flagged workflows to pin actions by SHA and use gh release create.
-
Related To:
canonical/imagecraft#402
(confidence 70%)
Issue notes the zizmor annotations surfaced as new PR annotations in #402 due to action version bumps.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #173 ci: pin all actions to SHAs | starflow | closed | Merged as commit 871da43, pinning GitHub Actions to commit SHAs to resolve Zizmor advisories; the unused snap-publish workflow was deferred. |