Pre-existing lint/type-check failures: mypy no-any-return in grubutil.py, pyright reportUnusedImport/reportMatchNotExhaustive/reportArgumentType
Metadata
Current evaluation
Pre-existing lint/type-check failures resolved: mypy no-any-return fixed in PR #452 (fbcd40d); pyright diagnostics cleared in current code.
Resolution: closed resolved
Reason: PR #452 merged as commit fbcd40d, adding an explicit int | None annotation in _part_num() to fix the mypy no-any-return error. The cited pyright reportUnusedImport, reportMatchNotExhaustive, and reportArgumentType diagnostics are no longer present in current code.
Evaluated by: mr-cal-bot
No scores available.
Issue body
🤖 [BEEP BOOP, A BOT WROTE THIS COMMENT - Claude Sonnet 5, GitHub Copilot CLI]
While validating [#402](https://github.com/canonical/imagecraft/pull/402) (the starbase merge), CI surfaced lint/type-check failures that are **pre-existing on `main`**, not introduced by that PR. Confirmed via a `git worktree` checkout of the pre-merge commit and running the same tools locally:
- `mypy`: `imagecraft/pack/grubutil.py:236: error: Returning Any from function declared to return "int | None" [no-any-return]`
- `pyright` (newly run in CI as part of `lint-pyright`, which this repo's `Makefile`/`common.mk` already wired up before the merge):
- `imagecraft/models/__init__.py:27:5` — `Import "BaseVolume" is not accessed (reportUnusedImport)`
- `imagecraft/services/image.py:261:19` — non-exhaustive `match` over `PartitionSchema.HYBRID` (`reportMatchNotExhaustive`)
- `tests/integration/services/test_project.py:47:18` and `:77:18` — `None` passed where `ServiceFactory` expected (`reportArgumentType`)
None of these lines were touched by the starbase merge. Filing so they're tracked and fixed independently rather than blocking/confusing future merge PRs.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| ~deepseek/deepseek-pro-latest | — | closed resolved | Pre-existing lint/type-check failures resolved: mypy no-any-return fixed in PR #452 (fbcd40d); pyright diagnostics cleared in current code. | |
| stealth/space-bunny-alpha |
Impact:
38
Quick Win:
26
Complexity:
27
Confidence:
95
Actionability:
94
|
close resolved | Pre-existing mypy/pyright CI diagnostics have been resolved; commit fbcd40d (PR #452) fixes grubutil's no-any-return, and current code resolves the other cited patterns. | |
| stealth/space-bunny-alpha |
Impact:
15
Quick Win:
12
Complexity:
10
Confidence:
88
Actionability:
90
|
close resolved | Bot-filed issue tracking pre-existing mypy/pyright failures on main (grubutil.py no-any-return, unused BaseVolume import, non-exhaustive match, test arg types). All four are now resolved at HEAD; file grubutil.py no longer exists. | |
| stealth/space-bunny-alpha |
Impact:
42
Quick Win:
28
Complexity:
31
Confidence:
92
Actionability:
96
|
close resolved | Reported pre-existing mypy/pyright CI failures have been addressed: fbcd40d fixes grubutil's no-any-return, while current code resolves the other cited lint patterns. | |
| stealth/space-bunny-alpha |
Impact:
30
Quick Win:
19
Complexity:
30
Confidence:
88
Actionability:
92
|
needs triage | Pre-existing mypy and pyright failures are precisely localized across production and test code, but the report remains unlabeled, open, and without maintainer discussion. | |
| stealth/space-bunny-alpha |
Impact:
42
Quick Win:
27
Complexity:
25
Confidence:
91
Actionability:
87
|
needs triage | Five confirmed, pre-existing mypy and pyright failures were separated from the starbase merge, but the issue has no labels, assignee, or maintainer follow-up. | |
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
50
Quick Win:
38
Staleness:
45
Complexity:
25
Confidence:
85
Support Request:
0
|
needs triage | Tracks pre-existing mypy and pyright lint/type-check failures on main: no-any-return in grubutil.py, unused import in models/__init__.py, non-exhaustive match in image.py, and argument type errors in tests. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
0
Complexity:
20
Confidence:
95
Support Request:
0
|
needs triage | Pre-existing mypy and pyright lint/type-check failures in grubutil.py, models/__init__.py, services/image.py, and test_project.py. Currently unlabelled and awaiting maintainer triage. |
Update history
| Date | Change |
|---|---|
| closed | |
| created |
Related work
-
Likely Fixed By:
canonical/imagecraft#452
(confidence 100%)
Merged as fbcd40d; fixes mypy no-any-return in grubutil.py.
-
Related To:
canonical/imagecraft#402
(confidence 80%)
Issue filed while validating the starbase merge; failures were pre-existing on main.
Related issues
No related issues found above the similarity threshold.