← Back to issue list

Update dependency urllib3 to v1.26.19 [SECURITY]

View original Github issue

Metadata

Project
imagecraft
Number
#41
Type
pull request
State
closed
Author
renovate[bot]
Labels
Created
Updated
Closed

Current evaluation

Superseded and closed without merging after the urllib3 security update was addressed in pull request #39. Renovate will ignore this update and open a new PR for future versions.

Suggested action:

No scores available.

Issue body

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [urllib3](https://togithub.com/urllib3/urllib3) ([changelog](https://togithub.com/urllib3/urllib3/blob/main/CHANGES.rst)) | `==1.26.18` -> `==1.26.19` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/urllib3/1.26.19?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/urllib3/1.26.19?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/urllib3/1.26.18/1.26.19?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/urllib3/1.26.18/1.26.19?slim=true)](https://docs.renovatebot.com/merge-confidence/) | ### GitHub Vulnerability Alerts #### [CVE-2024-37891](https://togithub.com/urllib3/urllib3/security/advisories/GHSA-34jh-p97f-mpxf) When using urllib3's proxy support with `ProxyManager`, the `Proxy-Authorization` header is only sent to the configured proxy, as expected. However, when sending HTTP requests *without* using urllib3's proxy support, it's possible to accidentally configure the `Proxy-Authorization` header even though it won't have any effect as the request is not using a forwarding proxy or a tunneling proxy. In those cases, urllib3 doesn't treat the `Proxy-Authorization` HTTP header as one carrying authentication material and thus doesn't strip the header on cross-origin redirects. Because this is a highly unlikely scenario, we believe the severity of this vulnerability is low for almost all users. Out of an abundance of caution urllib3 will automatically strip the `Proxy-Authorization` header during cross-origin redirects to avoid the small chance that users are doing this on accident. Users should use urllib3's proxy support or disable automatic redirects to achieve safe processing of the `Proxy-Authorization` header, but we still decided to strip the header by default in order to further protect users who aren't using the correct approach. ## Affected usages We believe the number of usages affected by this advisory is low. It requires all of the following to be true to be exploited: * Setting the `Proxy-Authorization` header without using urllib3's built-in proxy support. * Not disabling HTTP redirects. * Either not using an HTTPS origin server or for the proxy or target origin to redirect to a malicious origin. ## Remediation * Using the `Proxy-Authorization` header with urllib3's `ProxyManager`. * Disabling HTTP redirects using `redirects=False` when sending requests. * Not using the `Proxy-Authorization` header. --- ### Release Notes <details> <summary>urllib3/urllib3 (urllib3)</summary> ### [`v1.26.19`](https://togithub.com/urllib3/urllib3/compare/1.26.18...1.26.19) [Compare Source](https://togithub.com/urllib3/urllib3/compare/1.26.18...1.26.19) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "" in timezone Etc/UTC, Automerge - "every weekend" in timezone Etc/UTC. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/canonical/imagecraft). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQxMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Superseded and closed without merging after the urllib3 security update was addressed in pull request #39. Renovate will ignore this update and open a new PR for future versions.
qwen3.6-35b-a3b-mtp-q6 Closed without merging; the urllib3 security update was already addressed in PR #39. Renovate will ignore this specific update.
qwen3.6-35b-a3b-mtp-q6 Superseded and closed without merging; the urllib3 security update was already addressed in pull request #39. Renovate will ignore this PR.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#7 Update dependency urllib3 to v1.26.18 [SECURITY] - autoclosed imagecraft closed The urllib3 security update to v1.26.18 was autoclosed by Renovate without merging. The branch was automatically closed due to staleness or repository changes, leaving the dependency update unapplied.
84%
#1130 build(deps): update dependency urllib3 to v2.5.0 [security] (main) craft-parts closed Closed without merging as a duplicate of PR #1135, which also updates urllib3 and uv.lock. Renovate will ignore this update.
79%
#5596 build(deps): update dependency urllib3 to v2 [security] (hotfix/8.10) snapcraft closed Closed without merging after maintainers confirmed the dependency was unused. It was removed in PR #5598, rendering the urllib3 v2 security update unnecessary. Renovate will ignore future updates for this package.
79%
#40 Update dependency requests to v2.32.2 [SECURITY] imagecraft closed Superseded and closed without merging after the security update was addressed in pull request #39. Renovate will ignore this specific dependency update.
79%
#5564 build(deps): update dependency urllib3 to v2 [security] (hotfix/7.5) snapcraft closed The urllib3 security update to v2.5.0 was closed without merging. A maintainer marked the dependency as unused, prompting Renovate to ignore future minor and patch updates. The PR was rejected.
78%
#5563 build(deps): update dependency urllib3 to v2 [security] (main) snapcraft closed Closed without merging because the dependency file is unused. Renovate will ignore future urllib3 v2 updates for this repository.
78%
#5565 build(deps): update dependency urllib3 to v2 [security] (hotfix/8.9) snapcraft closed Closed without merging after a maintainer noted the dependency file is unused. The urllib3 v2 security update was rejected, and Renovate will ignore future updates for this package.
78%
#4860 chore(deps): update dependency urllib3 to v1.26.19 [security] - autoclosed snapcraft closed The urllib3 security update to v1.26.19 was autoclosed by Renovate due to a branch head mismatch. The dependency change was not merged and the automated pull request was automatically closed.
78%
#1131 build(deps): update dependency urllib3 to v2.5.0 [security] (hotfix/2.10) - autoclosed craft-parts closed Renovate automatically closed this urllib3 v2.5.0 security update without merging. The pull request was autoclosed, indicating it was superseded by a newer update or abandoned.
77%
#5 Bump urllib3 from 1.26.12 to 1.26.18 imagecraft closed Automated urllib3 update from 1.26.12 to 1.26.18 was closed as unnecessary. Dependabot confirmed the dependency is already current, superseding the proposed changes without merging.
76%