← Back to issue list

Update dependency urllib3 to v1.26.19 [SECURITY]

View original Github issue

Metadata

Project
imagecraft
Number
#41
Type
pull request
State
closed
Author
renovate[bot]
Labels
β€”
Created
Updated
Closed

Current evaluation

Closed unmerged as redundant with canonical/imagecraft#39, which maintainer @upils said handled the urllib3 1.26.19 update.

Resolution: closed superseded

Reason: Maintainer @upils commented, "Handled in canonical/imagecraft#39. Closing," and #41 was closed without merging. Renovate confirmed the unmerged update would be ignored.

Evaluated by: mr-cal-bot

No scores available.

Issue body

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [urllib3](https://togithub.com/urllib3/urllib3) ([changelog](https://togithub.com/urllib3/urllib3/blob/main/CHANGES.rst)) | `==1.26.18` -> `==1.26.19` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/urllib3/1.26.19?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/urllib3/1.26.19?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/urllib3/1.26.18/1.26.19?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/urllib3/1.26.18/1.26.19?slim=true)](https://docs.renovatebot.com/merge-confidence/) | ### GitHub Vulnerability Alerts #### [CVE-2024-37891](https://togithub.com/urllib3/urllib3/security/advisories/GHSA-34jh-p97f-mpxf) When using urllib3's proxy support with `ProxyManager`, the `Proxy-Authorization` header is only sent to the configured proxy, as expected. However, when sending HTTP requests *without* using urllib3's proxy support, it's possible to accidentally configure the `Proxy-Authorization` header even though it won't have any effect as the request is not using a forwarding proxy or a tunneling proxy. In those cases, urllib3 doesn't treat the `Proxy-Authorization` HTTP header as one carrying authentication material and thus doesn't strip the header on cross-origin redirects. Because this is a highly unlikely scenario, we believe the severity of this vulnerability is low for almost all users. Out of an abundance of caution urllib3 will automatically strip the `Proxy-Authorization` header during cross-origin redirects to avoid the small chance that users are doing this on accident. Users should use urllib3's proxy support or disable automatic redirects to achieve safe processing of the `Proxy-Authorization` header, but we still decided to strip the header by default in order to further protect users who aren't using the correct approach. ## Affected usages We believe the number of usages affected by this advisory is low. It requires all of the following to be true to be exploited: * Setting the `Proxy-Authorization` header without using urllib3's built-in proxy support. * Not disabling HTTP redirects. * Either not using an HTTPS origin server or for the proxy or target origin to redirect to a malicious origin. ## Remediation * Using the `Proxy-Authorization` header with urllib3's `ProxyManager`. * Disabling HTTP redirects using `redirects=False` when sending requests. * Not using the `Proxy-Authorization` header. --- ### Release Notes <details> <summary>urllib3/urllib3 (urllib3)</summary> ### [`v1.26.19`](https://togithub.com/urllib3/urllib3/compare/1.26.18...1.26.19) [Compare Source](https://togithub.com/urllib3/urllib3/compare/1.26.18...1.26.19) </details> --- ### Configuration πŸ“… **Schedule**: Branch creation - "" in timezone Etc/UTC, Automerge - "every weekend" in timezone Etc/UTC. 🚦 **Automerge**: Enabled. β™» **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. πŸ”• **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/canonical/imagecraft). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQxMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha β€” closed superseded Closed unmerged as redundant with canonical/imagecraft#39, which maintainer @upils said handled the urllib3 1.26.19 update.
stealth/space-bunny-alpha β€” closed superseded Closed unmerged as superseded by canonical/imagecraft#39, which handled the urllib3 1.26.19 security update. Renovate said it would ignore this version until a newer release.
qwen/qwen3.6-35b-a3b β€” β€” Superseded and closed without merging after the urllib3 security update was addressed in pull request #39. Renovate will ignore this update and open a new PR for future versions.
qwen3.6-35b-a3b-mtp-q6 β€” β€” Closed without merging; the urllib3 security update was already addressed in PR #39. Renovate will ignore this specific update.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/imagecraft#39 (confidence 100%)

    The closing maintainer explicitly identified this PR as handling the update.

Related issues

Issue Project State Summary Similarity
#7 Update dependency urllib3 to v1.26.18 [SECURITY] - autoclosed imagecraft closed Autoclosed without merge after 29 days; the proposed urllib3 1.26.12-to-1.26.18 security update received no reviews, comments, or CI checks.
80%
#5 Bump urllib3 from 1.26.12 to 1.26.18 imagecraft closed Dependabot’s urllib3 1.26.18 update was closed unmerged as obsolete after urllib3 had already been brought up to date.
77%
#1336 build(deps): bump urllib3 from 1.26.17 to 1.26.18 charmcraft closed Superseded unmerged by commit 25d6160d, which updated urllib3 to 1.26.18; Dependabot closed #1336 as already up to date.
75%
#195 build(deps): update dependency urllib3 to v1.26.20 (main) starflow closed Automated dependency update upgrading urllib3 to v1.26.20. Closed and merged into main by Renovate.
74%
#1307 build(deps): bump urllib3 from 1.26.16 to 1.26.17 charmcraft closed Dependabot closed #1307 unmerged as obsolete: the identical urllib3 1.26.16β†’1.26.17 security bump had already landed via #1308 (commit 51323d0f).
73%
#4860 chore(deps): update dependency urllib3 to v1.26.19 [security] - autoclosed snapcraft closed Autoclosed: duplicate of merged Dependabot PR #4859 (commit 60d370276), which already bumped urllib3 1.26.18 -> 1.26.19 (CVE-2024-37891) in main.
72%
#363 build(deps): bump urllib3 from 1.26.4 to 1.26.5 charmcraft merged Merged canonical/charmcraft#363 via bbc684ef, upgrading urllib3 from 1.26.4 to 1.26.5; merge commit bb424682 records the integration.
72%
#1408 fix(deps): update urllib3 to 2.5.1 to address security vulnerabilities craft-parts closed Closed unmerged; the urllib3 security update was superseded by merged PR #1411 (commit 044ea761), which upgraded uv.lock from urllib3 2.5.0 to 2.6.1.
72%
#4859 build(deps): bump urllib3 from 1.26.18 to 1.26.19 snapcraft merged Dependabot PR merged, bumping urllib3 1.26.18 to 1.26.19 in the main requirements (commit 60d370276, PR #4859); approved by 2 reviewers with no unresolved comments.
71%
#1308 chore(deps): update dependency urllib3 to v1.26.17 [security] charmcraft merged Renovate security bump of urllib3 1.26.16 -> 1.26.17 (CVE-2023-43804 Cookie header leak on redirect) merged into main as commit 51323d0f, changing2 dependency pin files.
70%