← Back to issue list

chore(deps): update dependency urllib3 to v1.26.19 [security] - autoclosed

View original Github issue

Metadata

Project
snapcraft
Number
#4860
Type
pull request
State
closed
Author
renovate[bot]
Labels
—
Created
Updated
Closed

Current evaluation

Autoclosed: duplicate of merged Dependabot PR #4859 (commit 60d370276), which already bumped urllib3 1.26.18 -> 1.26.19 (CVE-2024-37891) in main.

Resolution: closed superseded

Reason: The same urllib3 1.26.19 security bump was merged independently via Dependabot PR #4859 (commit 60d370276) before this Renovate PR could automerge, so #4860 was autoclosed as a branch-head mismatch / duplicate. Its intended one-line dependency change was already in main.

Evaluated by: mr-cal-bot

No scores available.

Issue body

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [urllib3](https://togithub.com/urllib3/urllib3) ([changelog](https://togithub.com/urllib3/urllib3/blob/main/CHANGES.rst)) | `==1.26.18` -> `==1.26.19` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/urllib3/1.26.19?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/urllib3/1.26.19?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/urllib3/1.26.18/1.26.19?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/urllib3/1.26.18/1.26.19?slim=true)](https://docs.renovatebot.com/merge-confidence/) | ### GitHub Vulnerability Alerts #### [CVE-2024-37891](https://togithub.com/urllib3/urllib3/security/advisories/GHSA-34jh-p97f-mpxf) When using urllib3's proxy support with `ProxyManager`, the `Proxy-Authorization` header is only sent to the configured proxy, as expected. However, when sending HTTP requests *without* using urllib3's proxy support, it's possible to accidentally configure the `Proxy-Authorization` header even though it won't have any effect as the request is not using a forwarding proxy or a tunneling proxy. In those cases, urllib3 doesn't treat the `Proxy-Authorization` HTTP header as one carrying authentication material and thus doesn't strip the header on cross-origin redirects. Because this is a highly unlikely scenario, we believe the severity of this vulnerability is low for almost all users. Out of an abundance of caution urllib3 will automatically strip the `Proxy-Authorization` header during cross-origin redirects to avoid the small chance that users are doing this on accident. Users should use urllib3's proxy support or disable automatic redirects to achieve safe processing of the `Proxy-Authorization` header, but we still decided to strip the header by default in order to further protect users who aren't using the correct approach. ## Affected usages We believe the number of usages affected by this advisory is low. It requires all of the following to be true to be exploited: * Setting the `Proxy-Authorization` header without using urllib3's built-in proxy support. * Not disabling HTTP redirects. * Either not using an HTTPS origin server or for the proxy or target origin to redirect to a malicious origin. ## Remediation * Using the `Proxy-Authorization` header with urllib3's `ProxyManager`. * Disabling HTTP redirects using `redirects=False` when sending requests. * Not using the `Proxy-Authorization` header. --- ### Release Notes <details> <summary>urllib3/urllib3 (urllib3)</summary> ### [`v1.26.19`](https://togithub.com/urllib3/urllib3/blob/HEAD/CHANGES.rst#12619-2024-06-17) [Compare Source](https://togithub.com/urllib3/urllib3/compare/1.26.18...1.26.19) \==================== - Added the `Proxy-Authorization` header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set via `Retry.remove_headers_on_redirect`. - Fixed handling of OpenSSL 3.2.0 new error message for misconfiguring an HTTP proxy as HTTPS. (`#&#8203;3405 <https://github.com/urllib3/urllib3/issues/3405>`\__) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "" in timezone Etc/UTC, Automerge - "every weekend" in timezone Etc/UTC. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/canonical/snapcraft). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Autoclosed: duplicate of merged Dependabot PR #4859 (commit 60d370276), which already bumped urllib3 1.26.18 -> 1.26.19 (CVE-2024-37891) in main.
stealth/space-bunny-alpha — closed superseded Renovate PR #4860 was autoclosed after a branch-head mismatch; the same urllib3 1.26.19 security bump was already merged via Dependabot PR #4859 (commit 60d370276).
qwen/qwen3.6-35b-a3b — — The urllib3 security update to v1.26.19 was autoclosed by Renovate due to a branch head mismatch. The dependency change was not merged and the automated pull request was automatically closed.
qwen3.6-35b-a3b-mtp-q6 — — Automated urllib3 update to v1.26.19 addressing CVE-2024-37891 was autoclosed due to branch staleness and merge conflicts. The dependency update was abandoned and never merged.

Update history

No update history recorded yet.

Related work

  • Duplicate Of: canonical/snapcraft#4859 (confidence 100%)

    Merged Dependabot PR performing the identical urllib3 1.26.18 -> 1.26.19 bump (commit 60d370276).

  • Likely Fixed By: canonical/snapcraft#4859 (confidence 95%)

    CVE-2024-37891 remediation landed on main through #4859, not through this PR.

  • Related To: canonical/snapcraft#4887 (confidence 90%)

    Sibling 1.26.18 -> 1.26.19 bump applied to the docs/.sphinx environment.

Related issues

Issue Project State Summary Similarity
#1337 chore(deps): update dependency urllib3 to v1.26.18 [security] charmcraft merged Merged PR #1337 as 25d6160d, upgrading urllib3 from 1.26.17 to 1.26.18 to remediate CVE-2023-45803.
93%
#1308 chore(deps): update dependency urllib3 to v1.26.17 [security] charmcraft merged Renovate security bump of urllib3 1.26.16 -> 1.26.17 (CVE-2023-43804 Cookie header leak on redirect) merged into main as commit 51323d0f, changing2 dependency pin files.
90%
#369 chore(deps): update dependency urllib3 to v2 craft-providers closed Renovate's urllib3 v2 update was closed unmerged because #264 pinned urllib3 to v1 pending msabramo/requests-unixsocket#69.
85%
#4859 build(deps): bump urllib3 from 1.26.18 to 1.26.19 snapcraft merged Dependabot PR merged, bumping urllib3 1.26.18 to 1.26.19 in the main requirements (commit 60d370276, PR #4859); approved by 2 reviewers with no unresolved comments.
79%
#339 chore(deps): update bugfixes rockcraft merged Renovate dependency bump PR merged as commit b72aed86 (urllib3 1.26.13->1.26.16, PyYAML 6.0->6.0.1, MarkupSafe, click, codespell, etc.) after the Pyright lint blocker was resolved in PR #342.
78%
#195 build(deps): update dependency urllib3 to v1.26.20 (main) starflow closed Automated dependency update upgrading urllib3 to v1.26.20. Closed and merged into main by Renovate.
78%
#1307 build(deps): bump urllib3 from 1.26.16 to 1.26.17 charmcraft closed Dependabot closed #1307 unmerged as obsolete: the identical urllib3 1.26.16→1.26.17 security bump had already landed via #1308 (commit 51323d0f).
77%
#1336 build(deps): bump urllib3 from 1.26.17 to 1.26.18 charmcraft closed Superseded unmerged by commit 25d6160d, which updated urllib3 to 1.26.18; Dependabot closed #1336 as already up to date.
77%
#7 Update dependency urllib3 to v1.26.18 [SECURITY] - autoclosed imagecraft closed Autoclosed without merge after 29 days; the proposed urllib3 1.26.12-to-1.26.18 security update received no reviews, comments, or CI checks.
76%
#1111 chore(deps): update dependency requests to v2.31.0 [security] - abandoned charmcraft closed Renovate's requests 2.28.2 -> 2.31.0 security PR was closed empty (0 files) after autoclosing was skipped due to a modified branch; the identical CVE-2023-32681 upgrade landed via merged Dependabot PR #1110 (10d6d55a).
76%