← Back to issue list

chore(deps): update dependency urllib3 to v1.26.19 [security] - autoclosed

View original Github issue

Metadata

Project
snapcraft
Number
#4860
Type
pull request
State
closed
Author
renovate[bot]
Labels
Created
Updated
Closed

Current evaluation

The urllib3 security update to v1.26.19 was autoclosed by Renovate due to a branch head mismatch. The dependency change was not merged and the automated pull request was automatically closed.

Suggested action:

No scores available.

Issue body

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [urllib3](https://togithub.com/urllib3/urllib3) ([changelog](https://togithub.com/urllib3/urllib3/blob/main/CHANGES.rst)) | `==1.26.18` -> `==1.26.19` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/urllib3/1.26.19?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/urllib3/1.26.19?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/urllib3/1.26.18/1.26.19?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/urllib3/1.26.18/1.26.19?slim=true)](https://docs.renovatebot.com/merge-confidence/) | ### GitHub Vulnerability Alerts #### [CVE-2024-37891](https://togithub.com/urllib3/urllib3/security/advisories/GHSA-34jh-p97f-mpxf) When using urllib3's proxy support with `ProxyManager`, the `Proxy-Authorization` header is only sent to the configured proxy, as expected. However, when sending HTTP requests *without* using urllib3's proxy support, it's possible to accidentally configure the `Proxy-Authorization` header even though it won't have any effect as the request is not using a forwarding proxy or a tunneling proxy. In those cases, urllib3 doesn't treat the `Proxy-Authorization` HTTP header as one carrying authentication material and thus doesn't strip the header on cross-origin redirects. Because this is a highly unlikely scenario, we believe the severity of this vulnerability is low for almost all users. Out of an abundance of caution urllib3 will automatically strip the `Proxy-Authorization` header during cross-origin redirects to avoid the small chance that users are doing this on accident. Users should use urllib3's proxy support or disable automatic redirects to achieve safe processing of the `Proxy-Authorization` header, but we still decided to strip the header by default in order to further protect users who aren't using the correct approach. ## Affected usages We believe the number of usages affected by this advisory is low. It requires all of the following to be true to be exploited: * Setting the `Proxy-Authorization` header without using urllib3's built-in proxy support. * Not disabling HTTP redirects. * Either not using an HTTPS origin server or for the proxy or target origin to redirect to a malicious origin. ## Remediation * Using the `Proxy-Authorization` header with urllib3's `ProxyManager`. * Disabling HTTP redirects using `redirects=False` when sending requests. * Not using the `Proxy-Authorization` header. --- ### Release Notes <details> <summary>urllib3/urllib3 (urllib3)</summary> ### [`v1.26.19`](https://togithub.com/urllib3/urllib3/blob/HEAD/CHANGES.rst#12619-2024-06-17) [Compare Source](https://togithub.com/urllib3/urllib3/compare/1.26.18...1.26.19) \==================== - Added the `Proxy-Authorization` header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set via `Retry.remove_headers_on_redirect`. - Fixed handling of OpenSSL 3.2.0 new error message for misconfiguring an HTTP proxy as HTTPS. (`#&#8203;3405 <https://github.com/urllib3/urllib3/issues/3405>`\__) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "" in timezone Etc/UTC, Automerge - "every weekend" in timezone Etc/UTC. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/canonical/snapcraft). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b The urllib3 security update to v1.26.19 was autoclosed by Renovate due to a branch head mismatch. The dependency change was not merged and the automated pull request was automatically closed.
qwen3.6-35b-a3b-mtp-q6 Automated urllib3 update to v1.26.19 addressing CVE-2024-37891 was autoclosed due to branch staleness and merge conflicts. The dependency update was abandoned and never merged.
qwen3.6-35b-a3b-mtp-q6 Renovate dependency update to urllib3 v1.26.19 for CVE-2024-37891 was autoclosed. The change was not merged, likely due to becoming outdated or being superseded by another update.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1337 chore(deps): update dependency urllib3 to v1.26.18 [security] charmcraft merged Merged automated update upgrading urllib3 from 1.26.17 to 1.26.18 to patch CVE-2023-45803, fixing HTTP request body leakage on 303 redirects. Approved and merged after passing CI checks.
87%
#1308 chore(deps): update dependency urllib3 to v1.26.17 [security] charmcraft merged Merged automated dependency update upgrading urllib3 from v1.26.16 to v1.26.17 to patch CVE-2023-43804, preventing Cookie header leakage via HTTP redirects. Approved by two reviewers, passed CI, and auto-merged.
87%
#7 Update dependency urllib3 to v1.26.18 [SECURITY] - autoclosed imagecraft closed The urllib3 security update to v1.26.18 was autoclosed by Renovate without merging. The branch was automatically closed due to staleness or repository changes, leaving the dependency update unapplied.
86%
#386 chore(deps): update dependency types-requests to v2.31.0.10 rockcraft closed Closed without merging due to a dependency conflict. A maintainer noted the update requires an incompatible urllib3 version. Renovate will ignore this specific update.
83%
#1132 build(deps): update dependency urllib3 to v2.5.0 [security] (hotfix/2.4) - autoclosed craft-parts closed Renovate automatically closed this urllib3 v2.5.0 security update without review or merge. The pull request was autoclosed, likely due to branch deletion or Renovate cleanup, leaving the change unapplied.
81%
#4773 chore(deps): update dependency pip to v23 [security] - autoclosed snapcraft closed Automatically closed without merging. The Renovate bot dependency update upgrading pip to v23.3 to address CVE-2023-5752 was abandoned, likely due to staleness or repository configuration.
80%
#1133 build(deps): update dependency urllib3 to v2.5.0 [security] (hotfix/2.7) - autoclosed craft-parts closed The urllib3 security update to v2.5.0 was autoclosed without review or merge. Generated by Renovate bot, the PR remained pending with zero reviewers and was ultimately abandoned.
80%
#1131 build(deps): update dependency urllib3 to v2.5.0 [security] (hotfix/2.10) - autoclosed craft-parts closed Renovate automatically closed this urllib3 v2.5.0 security update without merging. The pull request was autoclosed, indicating it was superseded by a newer update or abandoned.
80%
#4856 chore(deps): update dependency requests to v2.32.2 [security] - autoclosed snapcraft closed Renovate's dependency update PR for requests to v2.32.2 was autoclosed without merging. The bot automatically closed the stale pull request, leaving the CVE-2024-35195 security fix unapplied.
79%
#5564 build(deps): update dependency urllib3 to v2 [security] (hotfix/7.5) snapcraft closed The urllib3 security update to v2.5.0 was closed without merging. A maintainer marked the dependency as unused, prompting Renovate to ignore future minor and patch updates. The PR was rejected.
79%