build: install grub/ext4/blkid tooling in `make setup`
Metadata
Current evaluation
Merged to add grub-common, e2fsprogs, and util-linux to make setup. This resolves unit test failures by installing missing GRUB tooling, enabling rootless test execution. Approved by reviewers with passing CI.
Suggested action: —
No scores available.
Issue body
Part 1 of a stack that makes GRUB installation work without root privileges.
`tests/unit/pack/test_grubutil.py` has an autouse fixture that hard-fails
(rather than skips) when the GRUB tooling is missing, telling the developer to
run `make setup`. That advice did not actually work, because `make setup` only
installed `mtools`.
This adds the packages providing the other binaries the pack tests shell out to,
so that a fresh `make setup` is enough to run the test suite:
| Binary | Package |
| --- | --- |
| `grub-mkimage` | `grub-common` |
| `debugfs` | `e2fsprogs` |
| `blkid` | `util-linux` |
No production code changes.
IMAGECRAFT-176
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged to add grub-common, e2fsprogs, and util-linux to make setup. This resolves unit test failures by installing missing GRUB tooling, enabling rootless test execution. Approved by reviewers with passing CI. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
5
Confidence:
90
|
needs review | Adds grub-common, e2fsprogs, and util-linux packages to make setup to enable GRUB unit tests. Approved by two reviewers, CI passing except OSV-scanner. Ready for merge. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
5
Confidence:
80
|
needs review | Adds grub-common, e2fsprogs, and util-linux to make setup to enable GRUB unit tests. Approved by one reviewer, CI mostly passing except OSV-scanner. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
5
Confidence:
85
|
needs review | Adds grub-common, e2fsprogs, and util-linux to make setup to enable local GRUB unit tests without root. Approved by one reviewer, CI mostly passing with one OSV scanner failure and pending spread jobs. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
10
Confidence:
90
|
needs review | Adds grub-common, e2fsprogs, and util-linux to make setup to enable running pack tests without root. Approved by one reviewer, most CI passing, with pending builds and a minor OSV-scanner warning. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
10
Confidence:
95
|
needs review | Adds missing GRUB, ext4, and blkid packages to make setup to enable local unit tests. Approved by one reviewer, all CI checks passing, ready for maintainer review and merge. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
5
Confidence:
95
|
needs review | Adds grub-common, e2fsprogs, and util-linux to make setup to enable running GRUB tests without root. Approved by one reviewer, all CI checks passing, ready for merge. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
15
Confidence:
90
|
needs review | Adds grub-common, e2fsprogs, and util-linux packages to make setup to enable running GRUB unit tests without root privileges. Currently passing CI, awaiting review. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
5
Confidence:
90
|
needs review | Updates make setup to install grub-common, e2fsprogs, and util-linux packages, enabling local test execution without manual dependency installation. Currently passing CI, awaiting maintainer review. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
10
Confidence:
85
|
needs review | Updates make setup to install grub-common, e2fsprogs, and util-linux packages, enabling GRUB-related unit tests to run locally without root. Currently pending maintainer review with minor CI failures. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
10
Confidence:
85
|
needs review | Updates make setup to install grub-common, e2fsprogs, and util-linux, enabling local GRUB unit tests. Currently awaiting maintainer review with mixed CI status. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
10
Confidence:
90
|
needs review | Adds grub-common, e2fsprogs, and util-linux packages to make setup so GRUB unit tests run out-of-the-box. Currently awaiting maintainer review with CI checks in progress. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| updated | |
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #136 Test grub util | imagecraft | merged | Merged after two approvals and CI verification. Adds tests for setup_grub(). Initial check failures were resolved, and the change was merged following the completion of dependent PR 135. |