refactor: use upstream Application._get_app_plugins for plugin registration
Metadata
Current evaluation
Merged PR #476 refactors plugin registration to overload Application._get_app_plugins, letting craft-application register plugins via _register_default_plugins.
Resolution: closed resolved
Reason: PR #476 was merged after approval by 2 reviewers. It removes the manual plugins.setup_plugins() call in _enable_craft_parts_features and relies on upstream craft-application plugin registration.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Overload `Application._get_app_plugins` so craft-application handles plugin registration through `_register_default_plugins` during initialization instead of manually registering in `_enable_craft_parts_features`.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| ~deepseek/deepseek-pro-latest | — | closed resolved | Merged PR #476 refactors plugin registration to overload Application._get_app_plugins, letting craft-application register plugins via _register_default_plugins. | |
| ~deepseek/deepseek-pro-latest |
Impact:
35
Quick Win:
11
Complexity:
35
Confidence:
70
Actionability:
50
|
needs review | Overloads Application._get_app_plugins so craft-application registers imagecraft plugins via _register_default_plugins, removing the manual setup_plugins call. Approved by 2 reviewers; two spread tests failing. | |
| ~deepseek/deepseek-pro-latest |
Impact:
30
Quick Win:
11
Complexity:
35
Confidence:
70
Actionability:
55
|
needs review | Refactors plugin registration to override Application._get_app_plugins, letting craft-application register imagecraft plugins via _register_default_plugins; removes manual setup_plugins call. Approved but two spread CI jobs failing. | |
| ~deepseek/deepseek-pro-latest |
Impact:
35
Quick Win:
21
Complexity:
25
Confidence:
80
Actionability:
80
|
needs review | Overloads Application._get_app_plugins to return imagecraft plugins, letting craft-application register them via _register_default_plugins instead of manual setup_plugins. Small refactor, CI green, awaiting review. | |
| ~deepseek/deepseek-pro-latest |
Impact:
25
Quick Win:
17
Complexity:
15
Confidence:
80
Actionability:
80
|
needs review | Overloads Application._get_app_plugins to return imagecraft plugins, letting craft-application register them via _register_default_plugins instead of manual setup_plugins in _enable_craft_parts_features. Small refactor, CI green, awaiting review. | |
| ~deepseek/deepseek-pro-latest |
Impact:
25
Quick Win:
15
Complexity:
30
Confidence:
75
Actionability:
85
|
needs review | Refactor plugin registration to override Application._get_app_plugins so craft-application registers plugins during init, removing the manual setup_plugins call. Small diff, CI green, awaiting review. | |
| ~deepseek/deepseek-pro-latest |
Impact:
35
Quick Win:
17
Complexity:
25
Confidence:
75
Actionability:
65
|
needs review | Refactors plugin registration to use upstream Application._get_app_plugins; removes manual setup_plugins call. CI green, pending review with one unresolved review comment. |
Update history
| Date | Change |
|---|---|
| merged | |
| updated | |
| updated | |
| updated | |
| updated | |
| created |
Related work
-
Related To:
canonical/craft-application#174
(confidence 80%)
Upstream craft-application feature that supports registering default plugins, which this refactor uses.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #457 refactor: use craft-application plugins register | rockcraft | closed | Plugin-registration refactor PR #457 was closed as stale by @mr-cal on 2026-07-15; it was not merged. | |
| #1549 refactor: use the official means to register plugins | charmcraft | merged | Merged #1549 as commit 24da95e4, replacing custom plugin registration with craft-parts' official plugin registration mechanism. |