← Back to issue list

refactor: use the official means to register plugins

View original Github issue

Metadata

Project
charmcraft
Number
#1549
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged #1549 as commit 24da95e4, replacing custom plugin registration with craft-parts' official plugin registration mechanism.

Resolution: closed resolved

Reason: PR #1549 was approved by two reviewers and merged into main, delivering the plugin-registration refactor in commit 24da95e4.

Evaluated by: mr-cal-bot

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #1549 as commit 24da95e4, replacing custom plugin registration with craft-parts' official plugin registration mechanism.
stealth/space-bunny-alpha — closed resolved Merged #1549 in commit 24da95e4, replacing Charmcraft's custom plugin registration with the official API.
stealth/space-bunny-alpha — closed resolved Merged PR #1549 in commit 24da95e4, replacing custom plugin registration with the official API.
stealth/space-bunny-alpha — closed resolved Merged #1549 as commit 24da95e4, replacing Charmcraft's custom plugin-registration mechanism with the official API.
stealth/space-bunny-alpha — closed resolved Merged #1549, replacing custom plugin registration with the official API in one file (+6/-3). Approved by two reviewers and integrated into main.
qwen/qwen3.6-35b-a3b — — Merged a maintainer-led refactor replacing custom plugin registration with the official API. The change modified one file (+6/-3 lines), received approval from two reviewers, and was successfully integrated into the main branch.
qwen3.6-35b-a3b-mtp-q6 — — Merged a refactoring update that switches plugin registration to official methods. The change was integrated without comments or additional discussion.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#457 refactor: use craft-application plugins register rockcraft closed Plugin-registration refactor PR #457 was closed as stale by @mr-cal on 2026-07-15; it was not merged.
74%
#476 refactor: use upstream Application._get_app_plugins for plugin registration imagecraft merged Merged PR #476 refactors plugin registration to overload Application._get_app_plugins, letting craft-application register plugins via _register_default_plugins.
72%
#1897 refactor: move parts plugins to their own module charmcraft merged Merged PR #1897 (commit 392f859b), separating craft-parts plugins into charmcraft/parts/plugins and isolating them from other parts functionality.
71%