← Back to issue list

refactor: use upstream partition utilities and helpers

View original Github issue

Metadata

Project
imagecraft
Number
#479
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged refactor PR using craft_parts partition utilities and PackageService._prime_dir_for in imagecraft services/models.

Resolution: closed resolved

Reason: PR #479 was merged after approval with all CI checks passing; it replaces manual partition and prime-directory logic with upstream craft-parts helpers.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Uses `craft_parts.utils.partition_utils.DEFAULT_PARTITION` and `validate_partition_names` in `VolumeFilesystemsModel`, and replaces manual prime directory resolution in `ImagecraftPackService` with upstream `PackageService._prime_dir_for`.

Evaluation history

Date Model Scores Action Summary
~deepseek/deepseek-pro-latest — closed resolved Merged refactor PR using craft_parts partition utilities and PackageService._prime_dir_for in imagecraft services/models.
~deepseek/deepseek-pro-latest
Impact: 30
Quick Win: 22
Complexity: 25
Confidence: 85
Actionability: 100
needs review Refactors VolumeFilesystemsModel to use craft_parts partition utilities and ImagecraftPackService to use PackageService._prime_dir_for; approved, CI green.
~deepseek/deepseek-pro-latest
Impact: 30
Quick Win: 18
Complexity: 25
Confidence: 75
Actionability: 80
needs review Refactors VolumeFilesystemsModel to use craft_parts partition utilities and ImagecraftPackService to use upstream _prime_dir_for; CI green, awaiting review.
~deepseek/deepseek-pro-latest
Impact: 25
Quick Win: 14
Complexity: 20
Confidence: 75
Actionability: 70
needs review Refactors VolumeFilesystemsModel to use craft_parts partition utilities and ImagecraftPackService to use upstream _prime_dir_for; small diff, no reviews, CI pending.

Update history

Date Change
merged
updated
updated
created

Related issues

Issue Project State Summary Similarity
#5205 refactor: use craft-platforms utilities snapcraft merged Merged PR #5205 as commit 3aacad74b, replacing local architecture helpers with craft-platforms utilities and closing #4993 (CRAFT-3278).
70%