← Back to issue list

refactor: use craft-platforms utilities

View original Github issue

Metadata

Project
snapcraft
Number
#5205
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #5205 as commit 3aacad74b, replacing local architecture helpers with craft-platforms utilities and closing #4993 (CRAFT-3278).

Resolution: closed resolved

Reason: PR #5205 was approved and merged as commit 3aacad74b, replacing duplicated architecture handling with craft-platforms utilities and closing issue #4993.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox run -m lint`? - [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- Closes #4993. CRAFT-3278.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #5205 as commit 3aacad74b, replacing local architecture helpers with craft-platforms utilities and closing #4993 (CRAFT-3278).
stealth/space-bunny-alpha — closed resolved Merged PR #5205 as commit 3aacad74b, replacing local architecture helpers with craft-platforms utilities and closing #4993 (CRAFT-3278).
qwen/qwen3.6-35b-a3b — — Merged following approval by two reviewers. Refactored the codebase to use craft-platforms utilities, resolving CRAFT-3278 and closing #4993. Net reduction of 307 lines across 20 files.
qwen3.6-35b-a3b-mtp-q6 — — Merged refactor replacing platform handling with craft-platforms utilities, resolving issue #4993 and CRAFT-3278. Changes were integrated directly into the main branch without additional review comments.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/snapcraft#4993 (confidence 99%)

    PR #5205 explicitly states that it closes #4993 and implements CRAFT-3278.

Related issues

Issue Project State Summary Similarity
#4993 Use craft-platforms utilities snapcraft closed Fixed by merged PR #5205 (commit 3aacad74b, "refactor: use craft-platforms utilities"), which replaced snapcraft's own get_host_architecture/supported-architecture helpers with craft-platforms equivalents (CRAFT-3278).
76%
#495 feat: add craft-platforms compatibility methods craft-application merged Merged PR #495 as 3bd339cf, adding craft-platforms compatibility methods and pending-deprecation warnings; follow-up #498 repaired documentation builds.
74%
#403 [PROTOTYPE] refactor: use craft-platforms craft-application closed Closed unmerged as a prototype; maintainer redirected the craft-platforms build-planner integration to #391, with the build-plan service later landing via #666 (621d1a32).
72%
#715 refactor: use craft-platform for the build plans rockcraft merged Merged PR #715 (516d29e5) replaced Rockcraft’s custom build-plan generation with craft-platform, creating one shared source for Rockcraft and remote builds; fixes #698.
72%
#662 [PROTOTYPE] refactor: use craft-platforms rockcraft closed Prototype PR #662 was closed unmerged in August 2024; the production build-planner migration later landed via rockcraft#715 at commit 516d29e5.
72%
#1894 refactor: use craft-platforms for build plans charmcraft merged Merged PR #1894 (commit f1755e8f, +25/-33) replaced Charmcraft's custom build-plan generation for `platforms` charms with craft-platforms, routing exhaustive build plans through craft-application's BuildPlanService.
71%
#395 refactor: merge feature/craft-application rockcraft merged Merged PR #395 into main, completing the breaking migration to craft-application 1.0.0 and resolving seven linked migration and command issues.
71%
#521 refactor: port code to latest craft-app update rockcraft merged Merged PR #521 as de242431, migrating image and package services to craft-application 2.3.0's build plan without changing build semantics.
70%
#479 refactor: use upstream partition utilities and helpers imagecraft merged Merged refactor PR using craft_parts partition utilities and PackageService._prime_dir_for in imagecraft services/models.
70%