← Back to issue list

refactor: use craft-platforms utilities

View original Github issue

Metadata

Project
snapcraft
Number
#5205
Type
pull request
State
merged
Author
bepri
Labels
Created
Updated
Closed

Current evaluation

Merged following approval by two reviewers. Refactored the codebase to use craft-platforms utilities, resolving CRAFT-3278 and closing #4993. Net reduction of 307 lines across 20 files.

Suggested action:

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox run -m lint`? - [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- Closes #4993. CRAFT-3278.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged following approval by two reviewers. Refactored the codebase to use craft-platforms utilities, resolving CRAFT-3278 and closing #4993. Net reduction of 307 lines across 20 files.
qwen3.6-35b-a3b-mtp-q6 Merged refactor replacing platform handling with craft-platforms utilities, resolving issue #4993 and CRAFT-3278. Changes were integrated directly into the main branch without additional review comments.
qwen3.6-35b-a3b-mtp-q6 Merged a refactor to replace existing platform handling with craft-platforms utilities, resolving issue #4993 and addressing CRAFT-3278.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4682 refactor(app): use more code from craft-app snapcraft merged Merged a refactoring update consolidating app code by leveraging more craft-app functionality. Approved by two reviewers, passed CI and coverage checks, and modified three files with a net reduction of 13 lines.
82%
#1894 refactor: use craft-platforms for build plans charmcraft merged Merged a refactor replacing custom build plan logic with craft-platforms for platforms charms. Approved by two reviewers, the change modifies two files with a net reduction of eight lines, streamlining platform handling.
79%
#521 refactor: port code to latest craft-app update rockcraft merged Merged following two approvals and passing CI. Refactored image and package services to replace platform/build-for with the build plan, aligning with craft-application 2.3.0. Updates span 14 files (+106/-71 lines).
78%
#856 refactor: use craft-application 5 rockcraft merged Merged after three reviewers approved. The change refactored the codebase to adopt craft-application version 5, updating 49 files with 959 additions and 915 deletions. All checks passed.
76%
#398 Remove now unused functionalities (CRAFT-241). charmcraft merged Merged following approval by two reviewers. Removed unused functionalities referenced as CRAFT-241, altering two files with a net deletion of 229 lines. No unresolved review comments or CI checks were required.
76%
#715 refactor: use craft-platform for the build plans rockcraft merged Merged refactor to use craft-platform for build plans, creating a single source for Rockcraft and remote builds. Approved by two reviewers, resolving issue #698 with 31 additions and 3 deletions across five files.
76%
#515 refactor(docs): use more docs from craft-parts rockcraft merged Merged a documentation refactor simplifying the repository by directly referencing or embedding shared craft-parts docs. Approved by two reviewers, the update modifies 19 files, adding 61 and removing 38 lines.
76%
#4679 refactor(docs): use more docs from craft-parts snapcraft merged Merged documentation refactor replacing duplicated content with direct references or includes from shared craft-parts docs. Approved by two reviewers, passed CI, modified 18 files, and maintained 100% test coverage on changed lines.
76%
#1571 refactor: remove unused clean command implementation charmcraft merged Merged refactoring that removes the unused custom clean command and associated regression tests, as the project now uses the craft-application clean command. Approved by three reviewers, passed CI, and modified four files.
75%
#1334 refactor(parts): move craft-parts related things into their own package charmcraft merged Merged a refactor that moves craft-parts components into a dedicated package. Approved by two reviewers with zero unresolved comments. The change modifies 16 files, adding 960 lines and removing 794.
75%