style: fix linting issues
Metadata
Current evaluation
Merged lint/style fixes for four files (+7/-6) in canonical/imagecraft#494 via commit a5ff7fe; the remaining lint warning was an external ubuntu.com timeout.
Resolution: closed resolved
Reason: PR #494 was approved and merged as commit a5ff7fe, applying the requested linting fixes. The remaining lint failure was caused by a timeout accessing ubuntu.com rather than the code changes.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Quick changes for linting issues.
The remaining failure is due to the ongoing DDoS against ubuntu.com:
```
/home/runner/work/imagecraft/imagecraft/docs/common/craft-parts/explanation/lifecycle.rst:133: WARNING: timeout https://documentation.ubuntu.com/snapcraft/stable/explanation/parts-lifecycle/HTTPSConnectionPool(host='ubuntu.com', port=443): Read timed out. (read timeout=30)
```
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/imagecraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [x] I've added or updated any relevant documentation.
- [x] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| minimax/minimax-m3.1-flash:free | — | closed resolved | Merged lint/style fixes for four files (+7/-6) in canonical/imagecraft#494 via commit a5ff7fe; the remaining lint warning was an external ubuntu.com timeout. |
Update history
| Date | Change |
|---|---|
| merged | |
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #36 Lint | imagecraft | merged | Merged one-line lint cleanup in canonical/imagecraft#36 via commit 01f9b5d (merge commit 0623a54). | |
| #20 style: fix linting issues | craft-artifacts | merged | Merged PR #20 via commit 04cbdc0, applying style-only lint fixes across four files (+11/-5); both reviews approved and all CI checks passed. | |
| #5 style(lint): fix linting issues | starflow | merged | Merged in canonical/starflow#5 via commit 855660d, fixing lint/style issues in one file with a +3/-3 change. | |
| #2222 style: fix linting issues | charmcraft | merged | Merged PR #2222 as commit 31c109b4, applying style-only lint fixes across three files (+8/-9) with two approvals. | |
| #606 docs: yo dawg, I heard you like lint fixes | starbase | merged | Merged PR #606 (commit 3c932c5) fixed two documentation lint issues prompted by review on canonical/imagecraft#461. | |
| #1204 style: fix linting issues | craft-parts | closed | Lint-only cleanup landed in commit a0622b31, matching PR #1204’s title; all reported CI checks passed. | |
| #142 lint: fix linting issues with newer linters | craft-cli | merged | Merged #142 as commit aae948b, fixing newer-linter violations across five files; companion #144 updated CI and unblocked Ubuntu 18.04 tests. | |
| #580 style(ruff): fix linting issues from ruff update | craft-application | merged | Merged PR canonical/craft-application#580 (commit 97347705) by lengau applied style-only fixes (+7/-7, 3 files) for new lint failures caused by a Ruff update; approved by 3 reviewers. | |
| #901 style: fix ruff 0.13 linting issues | craft-application | merged | Merged in canonical/craft-application#901 via commit 0a659742, fixing Ruff 0.13 linting with a one-line change; review was approved and all CI checks passed. |