lint: fix linting issues with newer linters
Metadata
Current evaluation
Merged #142 as commit aae948b, fixing newer-linter violations across five files; companion #144 updated CI and unblocked Ubuntu 18.04 tests.
Resolution: closed resolved
Reason: PR #142 was merged as commit aae948b to resolve the linting failures. Its blocked Ubuntu 18.04 test job was addressed by companion PR #144, merged as b3d76e3.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Ubuntu 18.04 tests are stuck because GH actions removed 18.04. This is fixed in #144
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #142 as commit aae948b, fixing newer-linter violations across five files; companion #144 updated CI and unblocked Ubuntu 18.04 tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/craft-cli#142 to fix lint failures with newer linters across five files; companion #144 fixed the blocked Ubuntu 18.04 Actions job. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after reviewer approval and passing CI checks. Resolves linting failures caused by updated linter versions across five files. Ubuntu 18.04 GitHub Actions test failures were addressed separately in pull request #144. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/craft-cli#144
(confidence 98%)
Updated CI platforms and removed the blocked Ubuntu 18.04 tests required by #142.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #77 lint: fix linting issues with up-to-date linters | craft-store | merged | Merged PR #77 fixed lint failures with current linters across 11 files (+40/-24), with one approval and no unresolved review comments. | |
| #1204 style: fix linting issues | craft-parts | closed | Lint-only cleanup landed in commit a0622b31, matching PR #1204’s title; all reported CI checks passed. | |
| #494 lint: Set a linter conf and fix errors | fetch-service | merged | Merged PR #494 as commit 338bcaf, adding golangci-lint configuration and fixing lint errors across 117 files; all CI checks passed. | |
| #567 ci: fix linter issues | craft-parts | merged | PR #567 merged as c41f86d6, fixing CI linter issues across four files after approval. | |
| #18 lint: update linters | craft-archives | merged | Merged in canonical/craft-archives#18 via commit 41edc5b, updating linters across two files. | |
| #20 style: fix linting issues | craft-artifacts | merged | Merged PR #20 via commit 04cbdc0, applying style-only lint fixes across four files (+11/-5); both reviews approved and all CI checks passed. | |
| #3813 lint: bump pylint | snapcraft | merged | Merged in commit 522b301a9: updated Pylint and removed a redundant too-many-lines suppression across three files. | |
| #494 style: fix linting issues | imagecraft | merged | Merged lint/style fixes for four files (+7/-6) in canonical/imagecraft#494 via commit a5ff7fe; the remaining lint warning was an external ubuntu.com timeout. | |
| #1465 style: fix linting issues for newer ruff | craft-parts | merged | Merged #1465 as a58695ef, fixing five files (+13/-6) for compatibility with newer Ruff; all CI checks passed. | |
| #4815 linter updates | snapcraft | merged | Merged PR #4815, updating linter configuration across 10 files (+26/−56), after two approvals and with no unresolved review comments. |