← Back to issue list

feat: support grammar in Volumes section

View original Github issue

Metadata

Project
imagecraft
Number
#96
Type
pull request
State
merged
Author
upils
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #96 as b1674c7, adding Craft grammar support for Volumes and conditional partition-layout variations; fixes imagecraft#82 (CRAFT-4061).

Resolution: closed resolved

Reason: PR #96 was approved and merged via commit b1674c7. Implementation commit c1f7449 added grammar processing for the Volumes section and resolved the feature tracked by imagecraft#82.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? --- Support the craft grammar in the volumes section to enable defining variations around the disk partitions defined. Fixes #82 CRAFT-4061

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #96 as b1674c7, adding Craft grammar support for Volumes and conditional partition-layout variations; fixes imagecraft#82 (CRAFT-4061).
stealth/space-bunny-alpha — closed resolved Merged via b1674c7, adding Craft grammar support to Volumes so partition layouts can vary; fixes canonical/imagecraft#82 (CRAFT-4061).
qwen/qwen3.6-35b-a3b — — Merged after review approval. Adds craft grammar support to the volumes section for disk partition variations. Resolves #82 and CRAFT-4061. Proceeded after external dependency fixes were addressed.
qwen3.6-35b-a3b-mtp-q6 — — Merged to add craft grammar support to the Volumes section for disk partition variations. Resolves #82 and CRAFT-4061. Proceeded after external dependencies were addressed, despite noted Python 3.13 test failures.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: imagecraft#82 (confidence 100%)

    PR #96 explicitly states that it fixes the Volumes grammar feature issue.

  • Related To: canonical/craft-grammar#81 (confidence 98%)

    The maintainer cited this as the cause of Python 3.13 test failures; it was later fixed by craft-grammar PR #82.

  • Related To: canonical/craft-application#646 (confidence 95%)

    The maintainer cited this merged PR as necessary for grammar resolution before partition definition.

  • Related To: canonical/craft-grammar#73 (confidence 90%)

    The maintainer initially reported that this upstream fix was awaited before merging.

Related issues

Issue Project State Summary Similarity
#82 Support craft grammar in Volumes section imagecraft closed Craft grammar support for Volumes was implemented and merged in canonical/imagecraft#96 via b1674c7 (feature commit c1f7449), enabling platform-dependent partition layouts.
85%
#80 Support grammar in volumes section imagecraft closed Craft grammar support for volumes was added by merged PR canonical/imagecraft#96 in commit b1674c7.
83%
#73 feat: Implement Volumes specification subset imagecraft merged Merged PR #73 as commit 95256c7, implementing the selected Volumes specification subset and delivering CRAFT-3972.
73%
#88 feat: create craft partitions from structure items imagecraft merged Merged as commit 96b8742, adding dynamic craft-partition creation from structure items in the Volumes section and resolving imagecraft#81.
73%