← Back to issue list

feat: support grammar in Volumes section

View original Github issue

Metadata

Project
imagecraft
Number
#96
Type
pull request
State
merged
Author
upils
Labels
Created
Updated
Closed

Current evaluation

Merged after review approval. Adds craft grammar support to the volumes section for disk partition variations. Resolves #82 and CRAFT-4061. Proceeded after external dependency fixes were addressed.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? --- Support the craft grammar in the volumes section to enable defining variations around the disk partitions defined. Fixes #82 CRAFT-4061

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after review approval. Adds craft grammar support to the volumes section for disk partition variations. Resolves #82 and CRAFT-4061. Proceeded after external dependency fixes were addressed.
qwen3.6-35b-a3b-mtp-q6 Merged to add craft grammar support to the Volumes section for disk partition variations. Resolves #82 and CRAFT-4061. Proceeded after external dependencies were addressed, despite noted Python 3.13 test failures.
qwen3.6-35b-a3b-mtp-q6 Merged. Added grammar support to the Volumes section to enable disk partition variations, resolving issue #82. Integration proceeded after resolving dependencies on external craft-grammar and craft-application updates.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#73 feat: Implement Volumes specification subset imagecraft merged Merged implementation of a Volumes specification subset. Approved by two reviewers, the change adds 762 lines across 11 files and resolves CRAFT-3972.
76%
#82 Support craft grammar in Volumes section imagecraft closed Request to support craft grammar in the volumes section was closed without implementation. No fix or merge occurred, indicating the feature was deferred or abandoned. An internal Jira ticket was created, but no further progress was documented.
74%
#88 feat: create craft partitions from structure items imagecraft merged Merged implementation of dynamic craft partition creation from structure items in the Volumes section, resolving issue #81. Approved by two reviewers and passed CI checks across 12 files.
72%