← Back to issue list

feat: create craft partitions from structure items

View original Github issue

Metadata

Project
imagecraft
Number
#88
Type
pull request
State
merged
Author
upils
Labels
Created
Updated
Closed

Current evaluation

Merged implementation of dynamic craft partition creation from structure items in the Volumes section, resolving issue #81. Approved by two reviewers and passed CI checks across 12 files.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- Implement the dynamic craft partitions creation based on structures in the Volumes section. Fixes #81

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged implementation of dynamic craft partition creation from structure items in the Volumes section, resolving issue #81. Approved by two reviewers and passed CI checks across 12 files.
qwen3.6-35b-a3b-mtp-q6 Merged feature implementing dynamic craft partition creation from Volumes section structures, resolving issue #81.
qwen3.6-35b-a3b-mtp-q6 Merged dynamic craft partition creation from Volumes section structures, resolving issue #81. Changes passed linting and testing.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1110 feat: cleaning with partitions craft-parts merged Merged after craft-parts PR #1109. Properly cleans the shared area while accounting for partitions, resolving issue #665. Includes a changelog entry and passed three reviews.
78%
#763 partitions feature documentation craft-parts merged Merged documentation for the partitions feature targeting application developers. Approved by two reviewers, the update adds 66 lines and removes 5 across nine files, resolving CRAFT-3030.
75%
#81 Create craft partitions from structure items imagecraft closed Closed and transferred to internal Jira tickets CRAFT-4059 and CRAFT-4060. The feature request for dynamic partition creation was moved to internal tracking without a public pull request or merge.
75%
#493 partitions: validate usage of partitions in parts craft-parts merged Implemented partition validation for filepaths in the organize, overlay, stage, and prime keywords within parts. Merged after reviewer approval and passing CI checks, modifying seven files to resolve CRAFT-1844.
74%
#600 feat(partitions): handle namespaced partitions in utils craft-parts merged Merged following two reviewer approvals and passing CI. Updates utility functions to handle namespaced partitions across eight files (+229/-72 lines). Resolves #596 and CRAFT-2303.
73%
#1109 feat: track content migrated to partitions craft-parts merged Merged after craft-parts PR 1108. Introduces a partitions_contents key in state files to track content migrated to partitions. Resolves None versus default partition handling conflicts. Approved by three reviewers and passed CI checks.
73%
#673 feat(test): create partitioncraft craft-application merged Merged after dual approval, introducing partitioncraft to testcraft with basic lifecycle spread tests. One reviewer noted tests should be fixed before merge, but the changes were ultimately merged.
73%
#754 Document Partitions craft-parts closed Completed and merged via pull request #763 in canonical/craft-parts, adding the requested Partitions documentation to enable application integration and reuse.
72%
#96 feat: support grammar in Volumes section imagecraft merged Merged after review approval. Adds craft grammar support to the volumes section for disk partition variations. Resolves #82 and CRAFT-4061. Proceeded after external dependency fixes were addressed.
72%
#4463 Enable craft-parts partitions feature snapcraft closed Implemented craft-parts partitions by defining a default partition for snap data without altering existing behavior. Added spread tests for partition environment variables and keywords. Completed and merged via pull request #4493.
72%