fix: unhelpful error message when `base` is missing from YAML
Metadata
Current evaluation
Merged PR #1004 as commit d35c0828, fixing rockcraft#997 by returning a clear validation error when YAML omits the required base key.
Resolution: closed resolved
Reason: PR #1004 was merged as commit d35c0828 and explicitly fixes #997. Missing base data now produces a validation error instead of an internal AttributeError or KeyError.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Fixes #997
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1004 as commit d35c0828, fixing rockcraft#997 by returning a clear validation error when YAML omits the required base key. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged canonical/rockcraft#1004 (d35c0828), improving validation when YAML omits the required base key and resolving #997. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1004 via commit d35c0828, making a missing YAML base produce a validation error and resolving #997. Remaining lint and snap-test failures were documented as unrelated. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix that improves the error message when the base field is missing from YAML, resolving issue 997. Approved by two reviewers, the PR passed CI checks aside from unrelated known failures, and was successfully integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix improving the error message when the base field is missing from YAML. Resolves issue #997. Approved by maintainer @lengau, who noted unrelated test and lint failures were pre-existing. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/rockcraft#997
(confidence 100%)
The linked issue tracked unhelpful errors for missing required package-information keys and was resolved by this PR.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #123 fix: validate bare bases for rockcraft | craft-platforms | merged | Merged PR #123 (commit 80ac005) added bare-base validation for rocks: get_rock_build_plan now raises NeedsBuildBaseError when base is "bare" with no build-base. Shipped in 0.7.1. |