← Back to issue list

fix: validate bare bases for rockcraft

View original Github issue

Metadata

Project
craft-platforms
Number
#123
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #123 (commit 80ac005) added bare-base validation for rocks: get_rock_build_plan now raises NeedsBuildBaseError when base is "bare" with no build-base. Shipped in 0.7.1.

Resolution: closed resolved

Reason: The PR was merged into main as commit 80ac005 "fix: validate bare bases for rockcraft (#123)"; craft_platforms/rock/_build.py raises NeedsBuildBaseError when base == "bare" and build_base is None, covered by tests/unit/rock/test_build.py::test_bare_base_no_build_base and noted in changelog.rst under 0.7.1 (2025-04-10).

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- As part of the effort over at https://github.com/canonical/rockcraft/pull/856, it was found that craft-platforms needed to validate usage of the "bare" base. This PR adds that behavior.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #123 (commit 80ac005) added bare-base validation for rocks: get_rock_build_plan now raises NeedsBuildBaseError when base is "bare" with no build-base. Shipped in 0.7.1.
qwen/qwen3.6-35b-a3b — closed resolved Added validation for bare bases in craft-platforms to support rockcraft, addressing requirements identified in canonical/rockcraft#856.

Update history

Date Change
created

Related work

  • Related To: canonical/rockcraft#856 (confidence 85%)

    The PR body states the change was made as part of the effort in rockcraft PR #856, which uncovered the missing bare-base validation.

  • Related To: canonical/craft-platforms#127 (confidence 45%)

    Later commit 5115c05 'feat(rock): support Rockcraft legacy base names (#127)' extends get_rock_build_plan in the same file with legacy base mapping, adjacent work in the same code path.

Related issues

Issue Project State Summary Similarity
#1004 fix: unhelpful error message when `base` is missing from YAML rockcraft merged Merged PR #1004 as commit d35c0828, fixing rockcraft#997 by returning a clear validation error when YAML omits the required base key.
76%
#68 Possibly misleading error message when getting rock build plan craft-platforms closed Bare Rock bases now receive targeted validation instead of a misleading distribution-format error. Fixed by merged PR canonical/craft-platforms#123 (80ac005).
74%
#1310 fix: use get_project_base() in Extension.validate() rockcraft closed Merged PR canonical/rockcraft#1310 to use get_project_base() during Extension.validate(), respecting build-base precedence when base is bare.
72%