← Back to issue list

docs: make package-slices.svg readable in dark mode

View original Github issue

Metadata

Project
rockcraft
Number
#1107
Type
pull request
State
closed
Author
gcomneno
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged as superseded by canonical/rockcraft#1108, which provided a clean single-commit fix for package-slices.svg dark-mode readability (#840).

Resolution: closed superseded

Reason: The author stated that #1107 accidentally included unrelated commits and closed it in favor of #1108's clean single-commit implementation. #1107 was not merged.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fixes #840 The package slicing SVG used black strokes/fills on a transparent background, making arrows/text hard to see in dark mode. Use currentColor for black stroke/fill so the diagram follows the documentation theme.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged as superseded by canonical/rockcraft#1108, which provided a clean single-commit fix for package-slices.svg dark-mode readability (#840).
stealth/space-bunny-alpha — closed superseded Closed unmerged as superseded by #1108, a clean single-commit replacement for the #840 dark-mode SVG fix; #1107 accidentally included unrelated commits.
stealth/space-bunny-alpha — closed superseded Superseded by rockcraft#1108, a clean replacement for the dark-mode SVG fix; #1107 was not merged because it included unrelated commits.
stealth/space-bunny-alpha — closed superseded Closed as superseded by canonical/rockcraft#1108, which cleanly replaced black SVG strokes/fills to fix package-slices.svg readability in dark mode. This PR was not merged because it included unrelated commits.
qwen/qwen3.6-35b-a3b — — Superseded by PR #1108. The dark mode SVG fix was closed due to unrelated commits, with the resolution cleanly implemented in the replacement pull request.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by PR #1108, which cleanly resolves issue #840. The original PR updated an SVG diagram to use currentColor for dark mode compatibility but was closed after accidentally including unrelated commits.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/rockcraft#1108 (confidence 100%)

    Identical dark-mode SVG fix submitted as a clean replacement.

  • Related To: canonical/rockcraft#840 (confidence 100%)

    Original dark-mode readability issue targeted by both pull requests.

Related issues

Issue Project State Summary Similarity
#1108 docs: make package-slices.svg readable in dark mode rockcraft open Approved docs-only fix: replaces black strokes/fills in docs/_static/package-slices.svg with neutral greys/currentColor so the Chisel package-slicing diagram is readable in dark mode. Fixes #840; 2 approvals, no open comments, CI green apart from known persistent snap-tests failures.
81%