← Back to issue list

docs: make package-slices.svg readable in dark mode

View original Github issue

Metadata

Project
rockcraft
Number
#1108
Type
pull request
State
open
Author
gcomneno
Labels
—
Created
Updated
Closed
—

Current evaluation

Approved docs-only fix: replaces black strokes/fills in docs/_static/package-slices.svg with neutral greys/currentColor so the Chisel package-slicing diagram is readable in dark mode. Fixes #840; 2 approvals, no open comments, CI green apart from known persistent snap-tests failures.

Suggested action: needs review

Reason: The diff is a single 22-line cosmetic change to docs/_static/package-slices.svg (currently still on the original black-stroke version at HEAD, last touched in #271), it has 2 approvals and zero unresolved review comments, and the author already swapped currentColor for consistent neutral greys per feedback. The only failing check (snap-tests) was explicitly confirmed by maintainer @asanvaq as an 'expected/persistent' failure affecting all PRs, so it is not a blocker. It has been dormant for ~192 days with the author stating they will take no further action, so it simply needs a maintainer to land it; nothing has diverged and the file is unchanged since 2022, so closing as stale is not warranted.

Evaluated by: mr-cal-bot

Impact: 22 Quick Win: 15 Complexity: 8 Confidence: 88 Actionability: 74

Issue body

Fixes #840 The package slicing SVG used black strokes/fills on a transparent background, making arrows/text hard to see in dark mode. Use currentColor for black stroke/fill so the diagram follows the documentation theme.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 22
Quick Win: 15
Complexity: 8
Confidence: 88
Actionability: 74
needs review Approved docs-only fix: replaces black strokes/fills in docs/_static/package-slices.svg with neutral greys/currentColor so the Chisel package-slicing diagram is readable in dark mode. Fixes #840; 2 approvals, no open comments, CI green apart from known persistent snap-tests failures.
~deepseek/deepseek-pro-latest
Impact: 35
Quick Win: 29
Complexity: 8
Confidence: 88
Actionability: 90
needs review Replaces black SVG strokes/fills with neutral greys in package-slices.svg for dark-mode readability; approved by 2 reviewers, CI green except known persistent snap-tests failure.
qwen/qwen3.6-35b-a3b
Impact: 10
Quick Win: 2
Complexity: 5
Confidence: 95
Actionability: 20
close superseded Fixes dark-mode readability of package-slices.svg by replacing black strokes with neutral greys. Approved by 2 reviewers, CI passing (unrelated snap-tests failure noted by maintainer). Superseded by PR #1108.
qwen/qwen3.8-27b
Impact: 15
Quick Win: 14
Staleness: 80
Complexity: 5
Confidence: 80
close stale Docs fix restyling package-slices.svg with neutral greys for dark-mode readability. Approved by 2 reviewers, but closed as superseded by replacement PR #1108, which implements the same fix and is ready to merge.
qwen/qwen3.6-35b-a3b
Staleness: 45
Complexity: 10
Confidence: 90
needs review Updates package-slices.svg to use neutral greys for better dark mode readability. Approved by two reviewers with zero unresolved comments. CI shows one persistent unrelated failure. Ready to merge pending maintainer action.
qwen3.6-35b-a3b-mtp-q6
Staleness: 45
Complexity: 10
Confidence: 90
needs review Updates package-slices.svg to use neutral greys for improved dark mode readability. CI failures are confirmed unrelated. Awaiting maintainer review.
qwen3.6-35b-a3b-mtp-q6
Staleness: 75
Complexity: 10
Confidence: 75
needs review Updates package-slices.svg to use theme-aware colors for dark mode readability. CI failures are acknowledged as unrelated. The change is complete and ready for maintainer review.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/rockcraft#840 (confidence 92%)

    Open issue 'Graphs in Chisel Documentation not very readable in dark mode' describing exactly these black-on-transparent SVG arrows; this PR states it fixes it.

  • Related To: canonical/rockcraft#1107 (confidence 90%)

    Near-duplicate PR with the same title/goal, closed as superseded by this PR because it carried unrelated commits.

Related issues

Issue Project State Summary Similarity
#1107 docs: make package-slices.svg readable in dark mode rockcraft closed Closed unmerged as superseded by canonical/rockcraft#1108, which provided a clean single-commit fix for package-slices.svg dark-mode readability (#840).
81%
#840 Graphs in Chisel Documentation not very readable in dark mode rockcraft open Dark-mode readability report remains open, but commit 888acff0 (PR #1267) removed the Chisel graph and current chisel.rst no longer references package-slices.svg.
76%
#6169 docs: fix support chart colours for dark mode snapcraft open Docs-only CSS fix: adds dark-mode custom properties (--chart-pro-fill #aea79f, --chart-milestone-color #cd7c97) so Pro/Legacy bars and milestone markers in the support chart are visible; light mode unchanged. CLA passing, no reviewers yet.
71%