feat: finalize pro-sources support
Metadata
Current evaluation
Merged pro-sources support after approval; the feature landed in main through PR #1184 at commit 1987d98b.
Resolution: closed resolved
Reason: PR #1166 finalized pro-sources support and was merged. Merge PR #1184 brought feature/pro-sources into main in commit 1987d98b.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The first commit has craft-app updates and some 'busywork' from those. The second one has the actual feature.
The linting and docs failures are expected and unrelated. They are fixed in #1165 and after this is merged I'll do one more merge of `main` into `feature/pro-sources` before merging back.
---
- [ ] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md).
- [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [ ] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged pro-sources support after approval; the feature landed in main through PR #1184 at commit 1987d98b. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1166 finalized pro-sources support. The feature subsequently entered main through PR #1184 (commit 1987d98b). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval. Finalizes pro-sources support. Expected linting and test failures were acknowledged and will be resolved separately in #1165. Author confirmed the failures and a minor typo fix prior to merge. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to finalize pro-sources support, adding craft-app updates and core feature implementation. Expected linting, docs, and spread test failures were addressed separately or fixed inline by the maintainer prior to merge. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/rockcraft#1184
(confidence 99%)
Merged feature/pro-sources into main at commit 1987d98b.
-
Related To:
canonical/rockcraft#1165
(confidence 80%)
The author cited this merged PR as fixing expected unrelated failures.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #765 feat: add feature/pro-sources sources | rockcraft | closed | Pro-sources support was merged into main through #1184 (commit 1987d98b), incorporating the work proposed by #765 after that PR was closed. | |
| #955 feat: merge feature/pro-sources into main | rockcraft | closed | Draft PR merging feature/pro-sources into main was closed by @mr-cal as superseded by #1184, which squash-merged the same branch into main as commit 1987d98b (36 files, 2 approvals). | |
| #834 DRAFT: Merge in Pro-Sources | rockcraft | closed | Draft pro-sources integration was closed unmerged with a failing build; the feature later reached main through #1184 in commit 1987d98b. | |
| #877 feat: merge feature/pro-sources into main | craft-application | closed | Draft PR #877 (feature/pro-sources merge) was closed unmerged and superseded by #1050, which merged feature/pro-sources into main as commit 8c1a7aeb, resolving CRAFT-5016. | |
| #812 feat: merge feature/pro-sources into main | craft-providers | closed | Draft PR merging feature/pro-sources into main was closed unmerged; maintainer mr-cal closed it as superseded by #918, which merged the same branch into main with 2 approvals and all CI green. | |
| #926 Merge main in to feature/pro-sources | craft-parts | merged | Merged main into feature/pro-sources in PR #926, synchronizing the feature branch ahead of its planned merge into main. | |
| #582 chore: merge main with pro sources | craft-application | merged | Merged main into feature/pro-sources via PR #582 (commit 559ec1e5), resynchronizing the long-lived branch after two approvals. | |
| #6285 feat: enable pro support | snapcraft | merged | Merged PR #6285 in commit 704979f5e, enabling Pro support and adding a spread test for packing a Pro snap. |