← Back to issue list

feat: finalize pro-sources support

View original Github issue

Metadata

Project
rockcraft
Number
#1166
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged after approval. Finalizes pro-sources support. Expected linting and test failures were acknowledged and will be resolved separately in #1165. Author confirmed the failures and a minor typo fix prior to merge.

Suggested action:

No scores available.

Issue body

The first commit has craft-app updates and some 'busywork' from those. The second one has the actual feature. The linting and docs failures are expected and unrelated. They are fixed in #1165 and after this is merged I'll do one more merge of `main` into `feature/pro-sources` before merging back. --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approval. Finalizes pro-sources support. Expected linting and test failures were acknowledged and will be resolved separately in #1165. Author confirmed the failures and a minor typo fix prior to merge.
qwen3.6-35b-a3b-mtp-q6 Merged to finalize pro-sources support, adding craft-app updates and core feature implementation. Expected linting, docs, and spread test failures were addressed separately or fixed inline by the maintainer prior to merge.
qwen3.6-35b-a3b-mtp-q6 Merged to finalize pro-sources support with craft-app updates and the core feature. Linting and documentation failures were resolved separately. Spread test failures were expected due to ongoing bug fixes and a typo.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#6285 feat: enable pro support snapcraft merged Enabled Pro support and added a spread test for packing a pro snap. Merged after two approvals and 69 lines added across five files, despite failing integration and publish CI checks.
71%