feat: enable override-overlay
Metadata
Current evaluation
Merged. Updates craft-parts to enable the override-overlay key, replaces overlay-script in tests, and updates documentation. Reviewers approved the changes and confirmed upgrading sphinx-terminal resolves linting errors. All required checks passed before merge.
Suggested action: —
No scores available.
Issue body
- Updates craft-parts to enable `override-overlay` key
- Replaces `overlay-script` with `override-overlay` in a spread test which uses `useradd`
- Adds `override-overlay` to overlay-step explanation docs
(CRAFT-5026)
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [x] I've added or updated any relevant documentation.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. Updates craft-parts to enable the override-overlay key, replaces overlay-script in tests, and updates documentation. Reviewers approved the changes and confirmed upgrading sphinx-terminal resolves linting errors. All required checks passed before merge. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged the feature enabling the override-overlay key in craft-parts. Updated tests and documentation to replace overlay-script with override-overlay. Resolved documentation linting errors by upgrading sphinx-terminal to version 1.0.2 as recommended. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Enables the override-overlay key in craft-parts, updates spread tests, and documents the feature. Linting errors were resolved by upgrading sphinx-terminal to 1.0.2 per reviewer guidance. Addresses CRAFT-5026. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #299 feat: enable override-overlay | imagecraft | merged | Merged following approval from two reviewers and passing CI checks. Updated craft-parts to ~2.30 to enable override-overlay support and added a corresponding spread test. | |
| #1472 feat: add override-overlay | craft-parts | merged | Merged the override-overlay feature. Approved by two reviewers with 180 additions and 35 deletions across 10 files. Passed required CI checks and was successfully integrated into the codebase. | |
| #110 feat: Support overlay | imagecraft | merged | Merged to enable the overlay feature, provide a bare base, and add spread tests. Approved by two reviewers with passing CI checks. Resolves #98 and CRAFT-4269 across 18 files. | |
| #1473 docs: add override-overlay | craft-parts | merged | Merged documentation update adding override-overlay. Approved by three reviewers and passed CI checks despite two failing edge tests. Changes span six files with 20 additions and 8 deletions. | |
| #602 fix: enable overlays in _enable_craft_parts_features() | rockcraft | merged | Merged a fix enabling overlays in _enable_craft_parts_features(). Approved by two reviewers with passing CI checks. A minor testing note was dismissed when the reviewer used the correct environment. The change was successfully integrated. | |
| #1415 feat: add override-overlay | craft-parts | merged | Merged override-overlay, enabling scriptlets to run in a chroot. Adds grammar support, mutual exclusivity with overlay-script, chroot mountpoints, layer hashing, and tests. Approved and passed CI. | |
| #407 features: reorganize overlay feature tests | craft-parts | merged | Merged changes reorganizing overlay feature tests to run with the feature enabled and disabled. Fixes part environment setup to only set CRAFT_OVERLAY when active. Approved by reviewer and passed CI. | |
| #349 test: add overlay plugin integration test | imagecraft | merged | Merged following successful CI checks and dual reviewer approval. The update adds integration tests for overlay plugin commands and bumps the craft-parts dependency across eight files. |