← Back to issue list

feat: enable override-overlay

View original Github issue

Metadata

Project
rockcraft
Number
#1165
Type
pull request
State
merged
Author
smethnani
Labels
—
Created
Updated
Closed

Current evaluation

Merged in rockcraft#1165 via commit 1024f092, enabling override-overlay, updating a spread test from overlay-script, and documenting the key.

Resolution: closed resolved

Reason: PR #1165 was approved and merged as commit 1024f092. It upgraded craft-parts to expose override-overlay, migrated the useradd spread test, and added overlay-step documentation.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- Updates craft-parts to enable `override-overlay` key - Replaces `overlay-script` with `override-overlay` in a spread test which uses `useradd` - Adds `override-overlay` to overlay-step explanation docs (CRAFT-5026) --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in rockcraft#1165 via commit 1024f092, enabling override-overlay, updating a spread test from overlay-script, and documenting the key.
stealth/space-bunny-alpha — closed resolved Merged PR #1165 (commit 1024f092) enabled override-overlay, updated the useradd spread test, and documented the key.
qwen/qwen3.6-35b-a3b — — Merged. Updates craft-parts to enable the override-overlay key, replaces overlay-script in tests, and updates documentation. Reviewers approved the changes and confirmed upgrading sphinx-terminal resolves linting errors. All required checks passed before merge.
qwen3.6-35b-a3b-mtp-q6 — — Merged the feature enabling the override-overlay key in craft-parts. Updated tests and documentation to replace overlay-script with override-overlay. Resolved documentation linting errors by upgrading sphinx-terminal to version 1.0.2 as recommended.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/craft-parts#1472 (confidence 99%)

    Upstream commit 43dc8484 added the override-overlay implementation enabled by this PR.

  • Related To: canonical/craft-parts#1473 (confidence 98%)

    Upstream commit 1b2b7d5a documented override-overlay, complementing Rockcraft's documentation update.

Related issues

Issue Project State Summary Similarity
#299 feat: enable override-overlay imagecraft merged Merged in #299 via commit 6d283be, upgrading craft-parts to ~=2.30 and adding spread coverage for override-overlay support.
83%
#1472 feat: add override-overlay craft-parts merged Merged #1472 (43dc8484), adding override-overlay scriptlets that run during the overlay step in a chroot, with validation and tests.
79%
#1415 feat: add override-overlay craft-parts merged Merged override-overlay support via #1472 (43dc8484), adding chrooted scriptlets, validation, mounts, hashing, and tests; docs followed in #1473 for 2.30.0.
77%
#1473 docs: add override-overlay craft-parts merged Merged into main as #1473 (commit 1b2b7d5a), documenting the override-overlay key and recording the feature introduced by #1472 in the changelog.
75%
#602 fix: enable overlays in _enable_craft_parts_features() rockcraft merged Merged #602 (commit 86153dcc), enabling Craft Parts overlays during Rockcraft initialization via Features(enable_overlay=True).
72%
#322 docs: enable inclusion of overlay document rockcraft merged Merged PR #322 in commit 181c9e1c, enabling inclusion of the Craft Parts overlay document in Rockcraft's documentation.
71%
#436 feat(docs): add definition for overlay_step in the docs rockcraft merged Merged into Rockcraft, PR #436 added the missing overlay-step definition; maintainers chose its local wording instead of delaying for shared Craft Parts documentation.
71%
#110 feat: Support overlay imagecraft merged Merged in imagecraft#110 (00f1348), enabling overlays and empty bases with spread coverage for overlays combined with partitions; fixes #98.
70%